]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
hwmon: (max6642 fix coccinelle warnings
authorFengguang Wu <fengguang.wu@intel.com>
Wed, 18 Sep 2013 03:54:11 +0000 (20:54 -0700)
committerGuenter Roeck <linux@roeck-us.net>
Fri, 18 Oct 2013 16:11:59 +0000 (09:11 -0700)
drivers/hwmon/max6642.c:299:1-3: WARNING: PTR_RET can be used

 Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR

Generated by: coccinelle/api/ptr_ret.cocci

CC: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/max6642.c

index 3d61f8d719d546756b16f53989e1535070384ea2..8326fbd601508d354f5a037aabdc5420b1018670 100644 (file)
@@ -296,10 +296,7 @@ static int max6642_probe(struct i2c_client *client,
        hwmon_dev = devm_hwmon_device_register_with_groups(&client->dev,
                                                           client->name, data,
                                                           max6642_groups);
-       if (IS_ERR(hwmon_dev))
-               return PTR_ERR(hwmon_dev);
-
-       return 0;
+       return PTR_ERR_OR_ZERO(hwmon_dev);
 }
 
 /*