]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
extcon: Change permission 'state' sysfs entry (rw -> r)
authorChanwoo Choi <cw00.choi@samsung.com>
Wed, 22 May 2013 10:31:59 +0000 (19:31 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 17 Jun 2013 23:02:33 +0000 (16:02 -0700)
This patch change permission from read/write to only read.
The specific process in the user-space couldn't change the state
of cable when cable is attached or detached.
- /sys/class/extcon/[devine name]/state

Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
Signed-off-by: Myungjoo Ham <myungjoo.ham@samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/extcon/extcon-class.c

index 60adc04b0561ae600e215568873f3dc73bb0c84f..a5a03ae069eed2c302c6434468c728a3265c346f 100644 (file)
@@ -185,26 +185,6 @@ static ssize_t cable_state_show(struct device *dev,
                                               cable->cable_index));
 }
 
-static ssize_t cable_state_store(struct device *dev,
-                                struct device_attribute *attr, const char *buf,
-                                size_t count)
-{
-       struct extcon_cable *cable = container_of(attr, struct extcon_cable,
-                                                 attr_state);
-       int ret, state;
-
-       ret = sscanf(buf, "%d", &state);
-       if (ret == 0)
-               ret = -EINVAL;
-       else
-               ret = extcon_set_cable_state_(cable->edev, cable->cable_index,
-                                             state);
-
-       if (ret < 0)
-               return ret;
-       return count;
-}
-
 /**
  * extcon_update_state() - Update the cable attach states of the extcon device
  *                     only for the masked bits.
@@ -665,9 +645,8 @@ int extcon_dev_register(struct extcon_dev *edev, struct device *dev)
 
                        sysfs_attr_init(&cable->attr_state.attr);
                        cable->attr_state.attr.name = "state";
-                       cable->attr_state.attr.mode = 0644;
+                       cable->attr_state.attr.mode = 0444;
                        cable->attr_state.show = cable_state_show;
-                       cable->attr_state.store = cable_state_store;
                }
        }