usb: phy: fix error handling in usb_get_phy

spin_unlock_irqrestore() was not being called in the error path of
usb_get_phy. It's fixed here.

Reported-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>

diff --git a/drivers/usb/otg/otg.c b/drivers/usb/otg/otg.c
index 88d62b16f63273a712c42302337050f7c04ffded..1bf60a22595c706c2213720b1514391002e6284b 100644 (file)
--- a/drivers/usb/otg/otg.c
+++ b/drivers/usb/otg/otg.c
@@ -98,11 +98,12 @@ struct usb_phy *usb_get_phy(enum usb_phy_type type)
        if (IS_ERR(phy)) {
                pr_err("unable to find transceiver of type %s\n",
                        usb_phy_type_string(type));
-               return phy;
+               goto err0;
        }
 
        get_device(phy->dev);
 
+err0:
        spin_unlock_irqrestore(&phy_lock, flags);
 
        return phy;