]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
sata_mv: Delete unnecessary checks before the function call "phy_power_off"
authorMarkus Elfring <elfring@users.sourceforge.net>
Mon, 2 Feb 2015 21:55:53 +0000 (22:55 +0100)
committerTejun Heo <tj@kernel.org>
Tue, 3 Feb 2015 12:05:04 +0000 (07:05 -0500)
The phy_power_off() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Tejun Heo <tj@kernel.org>
drivers/ata/sata_mv.c

index f9a0e34eb111188ad152400a4ec733561ec755e7..f8c33e3772b823e123f4b32c2c066608297e06c2 100644 (file)
@@ -4185,8 +4185,7 @@ err:
                        clk_disable_unprepare(hpriv->port_clks[port]);
                        clk_put(hpriv->port_clks[port]);
                }
-               if (hpriv->port_phys[port])
-                       phy_power_off(hpriv->port_phys[port]);
+               phy_power_off(hpriv->port_phys[port]);
        }
 
        return rc;
@@ -4216,8 +4215,7 @@ static int mv_platform_remove(struct platform_device *pdev)
                        clk_disable_unprepare(hpriv->port_clks[port]);
                        clk_put(hpriv->port_clks[port]);
                }
-               if (hpriv->port_phys[port])
-                       phy_power_off(hpriv->port_phys[port]);
+               phy_power_off(hpriv->port_phys[port]);
        }
        return 0;
 }