]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
target: go through normal processing for all zero-length commands
authorPaolo Bonzini <pbonzini@redhat.com>
Mon, 17 Sep 2012 23:36:11 +0000 (16:36 -0700)
committerNicholas Bellinger <nab@linux-iscsi.org>
Tue, 18 Sep 2012 00:13:39 +0000 (17:13 -0700)
commitd81cb44726f050d7cf1be4afd9cb45d153b52066
tree8c977e5217f7c40a5a6c9938a4acb73737c129a5
parente0de44573637ba43e43ae1af042e109bbf2b6dd0
target: go through normal processing for all zero-length commands

Yay, all users of transport_kmap_data_sg now check for a zero-length
request and/or a too-small parameter list length.  We can thus go through
the normal emulation path even for such commands.

This means that out-of-bounds reads and writes are now reported correctly
even if they transfer 0 blocks.  Other errors are also reported correctly.

Testcase: sg_raw /dev/sdb 28 00 80 00 00 00 00 00 00 00
    should fail with ILLEGAL REQUEST / LBA OUT OF RANGE sense
    does not fail without the patch
    (still wrong with the patch, but better: the ASC is INVALID FIELD IN CDB)

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
drivers/target/target_core_transport.c