]> git.kernelconcepts.de Git - karo-tx-uboot.git/blobdiff - board/trizepsiv/eeprom.c
cmd_usage(): simplify return code handling
[karo-tx-uboot.git] / board / trizepsiv / eeprom.c
index fede2e077472b6d6c0fd41eccb26f58e956f0be3..fd623df25f27dc24c1cbc9ec5128108fdd99a99a 100644 (file)
@@ -42,36 +42,29 @@ static int do_read_dm9000_eeprom ( cmd_tbl_t *cmdtp, int flag, int argc, char *
 static int do_write_dm9000_eeprom ( cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) {
        int offset,value;
 
-       if (argc < 4) {
-               cmd_usage(cmdtp);
-               return 1;
-       }
+       if (argc < 4)
+               return cmd_usage(cmdtp);
 
        offset=simple_strtoul(argv[2],NULL,16);
        value=simple_strtoul(argv[3],NULL,16);
        if (offset > 0x40) {
                printf("Wrong offset : 0x%x\n",offset);
-               cmd_usage(cmdtp);
-               return 1;
+               return cmd_usage(cmdtp);
        }
        dm9000_write_srom_word(offset, value);
        return (0);
 }
 
 int do_dm9000_eeprom ( cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) {
-       if (argc < 2) {
-               cmd_usage(cmdtp);
-               return 1;
-       }
+       if (argc < 2)
+               return cmd_usage(cmdtp);
 
-       if (strcmp (argv[1],"read") == 0) {
+       if (strcmp (argv[1],"read") == 0)
                return (do_read_dm9000_eeprom(cmdtp,flag,argc,argv));
-       } else if (strcmp (argv[1],"write") == 0) {
+       else if (strcmp (argv[1],"write") == 0)
                return (do_write_dm9000_eeprom(cmdtp,flag,argc,argv));
-       } else {
-               cmd_usage(cmdtp);
-               return 1;
-       }
+       else
+               return cmd_usage(cmdtp);
 }
 
 U_BOOT_CMD(