]> git.kernelconcepts.de Git - karo-tx-uboot.git/blobdiff - common/cmd_fdt.c
Merge branch 'master' of git://git.denx.de/u-boot-usb
[karo-tx-uboot.git] / common / cmd_fdt.c
index 14c3fa022e0c256ad8c73ed345b485f568ca7a0a..9e2de34737f358fab0b9619b20b1e34ec0094e5c 100644 (file)
@@ -35,6 +35,9 @@
 
 #define MAX_LEVEL      32              /* how deeply nested we will go */
 #define SCRATCHPAD     1024            /* bytes of scratchpad memory */
+#ifndef CONFIG_CMD_FDT_MAX_DUMP
+#define CONFIG_CMD_FDT_MAX_DUMP 64
+#endif
 
 /*
  * Global data (for the gd->bd)
 DECLARE_GLOBAL_DATA_PTR;
 
 static int fdt_valid(void);
-static int fdt_parse_prop(char *pathp, char *prop, char *newval,
-       char *data, int *len);
+static int fdt_parse_prop(char *const*newval, int count, char *data, int *len);
 static int fdt_print(const char *pathp, char *prop, int depth);
+static int is_printable_string(const void *data, int len);
 
 /*
- * Flattened Device Tree command, see the help for parameter definitions.
+ * The working_fdt points to our working flattened device tree.
+ */
+struct fdt_header *working_fdt;
+
+void set_working_fdt_addr(void *addr)
+{
+       char buf[17];
+
+       working_fdt = addr;
+
+       sprintf(buf, "%lx", (unsigned long)addr);
+       setenv("fdtaddr", buf);
+}
+
+/*
+ * Get a value from the fdt and format it to be set in the environment
  */
-int do_fdt (cmd_tbl_t * cmdtp, int flag, int argc, char *argv[])
+static int fdt_value_setenv(const void *nodep, int len, const char *var)
 {
-       if (argc < 2) {
-               printf ("Usage:\n%s\n", cmdtp->usage);
+       if (is_printable_string(nodep, len))
+               setenv(var, (void *)nodep);
+       else if (len == 4) {
+               char buf[11];
+
+               sprintf(buf, "0x%08X", *(uint32_t *)nodep);
+               setenv(var, buf);
+       } else if (len%4 == 0 && len <= 20) {
+               /* Needed to print things like sha1 hashes. */
+               char buf[41];
+               int i;
+
+               for (i = 0; i < len; i += sizeof(unsigned int))
+                       sprintf(buf + (i * 2), "%08x",
+                               *(unsigned int *)(nodep + i));
+               setenv(var, buf);
+       } else {
+               printf("error: unprintable value\n");
                return 1;
        }
+       return 0;
+}
 
-       /********************************************************************
+/*
+ * Flattened Device Tree command, see the help for parameter definitions.
+ */
+static int do_fdt(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
+{
+       if (argc < 2)
+               return CMD_RET_USAGE;
+
+       /*
         * Set the address of the fdt
-        ********************************************************************/
+        */
        if (argv[1][0] == 'a') {
+               unsigned long addr;
                /*
                 * Set the address [and length] of the fdt.
                 */
-               fdt = (struct fdt_header *)simple_strtoul(argv[2], NULL, 16);
+               if (argc == 2) {
+                       if (!fdt_valid()) {
+                               return 1;
+                       }
+                       printf("The address of the fdt is %p\n", working_fdt);
+                       return 0;
+               }
+
+               addr = simple_strtoul(argv[2], NULL, 16);
+               set_working_fdt_addr((void *)addr);
 
                if (!fdt_valid()) {
                        return 1;
@@ -76,15 +130,15 @@ int do_fdt (cmd_tbl_t * cmdtp, int flag, int argc, char *argv[])
                         * Optional new length
                         */
                        len = simple_strtoul(argv[3], NULL, 16);
-                       if (len < fdt_totalsize(fdt)) {
+                       if (len < fdt_totalsize(working_fdt)) {
                                printf ("New length %d < existing length %d, "
                                        "ignoring.\n",
-                                       len, fdt_totalsize(fdt));
+                                       len, fdt_totalsize(working_fdt));
                        } else {
                                /*
                                 * Open in place with a new length.
                                 */
-                               err = fdt_open_into(fdt, fdt, len);
+                               err = fdt_open_into(working_fdt, working_fdt, len);
                                if (err != 0) {
                                        printf ("libfdt fdt_open_into(): %s\n",
                                                fdt_strerror(err));
@@ -92,23 +146,32 @@ int do_fdt (cmd_tbl_t * cmdtp, int flag, int argc, char *argv[])
                        }
                }
 
-       /********************************************************************
-        * Move the fdt
-        ********************************************************************/
-       } else if ((argv[1][0] == 'm') && (argv[1][1] == 'o')) {
+               return CMD_RET_SUCCESS;
+       }
+
+       if (!working_fdt) {
+               puts(
+                       "No FDT memory address configured. Please configure\n"
+                       "the FDT address via \"fdt addr <address>\" command.\n"
+                       "Aborting!\n");
+               return CMD_RET_FAILURE;
+       }
+
+       /*
+        * Move the working_fdt
+        */
+       if (strncmp(argv[1], "mo", 2) == 0) {
                struct fdt_header *newaddr;
                int  len;
                int  err;
 
-               if (argc < 4) {
-                       printf ("Usage:\n%s\n", cmdtp->usage);
-                       return 1;
-               }
+               if (argc < 4)
+                       return CMD_RET_USAGE;
 
                /*
                 * Set the address and length of the fdt.
                 */
-               fdt = (struct fdt_header *)simple_strtoul(argv[2], NULL, 16);
+               working_fdt = (struct fdt_header *)simple_strtoul(argv[2], NULL, 16);
                if (!fdt_valid()) {
                        return 1;
                }
@@ -120,13 +183,13 @@ int do_fdt (cmd_tbl_t * cmdtp, int flag, int argc, char *argv[])
                 * current length.
                 */
                if (argc <= 4) {
-                       len = fdt_totalsize(fdt);
+                       len = fdt_totalsize(working_fdt);
                } else {
                        len = simple_strtoul(argv[4], NULL, 16);
-                       if (len < fdt_totalsize(fdt)) {
+                       if (len < fdt_totalsize(working_fdt)) {
                                printf ("New length 0x%X < existing length "
                                        "0x%X, aborting.\n",
-                                       len, fdt_totalsize(fdt));
+                                       len, fdt_totalsize(working_fdt));
                                return 1;
                        }
                }
@@ -134,18 +197,18 @@ int do_fdt (cmd_tbl_t * cmdtp, int flag, int argc, char *argv[])
                /*
                 * Copy to the new location.
                 */
-               err = fdt_open_into(fdt, newaddr, len);
+               err = fdt_open_into(working_fdt, newaddr, len);
                if (err != 0) {
                        printf ("libfdt fdt_open_into(): %s\n",
                                fdt_strerror(err));
                        return 1;
                }
-               fdt = newaddr;
+               working_fdt = newaddr;
 
-       /********************************************************************
+       /*
         * Make a new node
-        ********************************************************************/
-       } else if ((argv[1][0] == 'm') && (argv[1][1] == 'k')) {
+        */
+       } else if (strncmp(argv[1], "mk", 2) == 0) {
                char *pathp;            /* path */
                char *nodep;            /* new node to add */
                int  nodeoffset;        /* node offset from libfdt */
@@ -154,15 +217,13 @@ int do_fdt (cmd_tbl_t * cmdtp, int flag, int argc, char *argv[])
                /*
                 * Parameters: Node path, new node to be appended to the path.
                 */
-               if (argc < 4) {
-                       printf ("Usage:\n%s\n", cmdtp->usage);
-                       return 1;
-               }
+               if (argc < 4)
+                       return CMD_RET_USAGE;
 
                pathp = argv[2];
                nodep = argv[3];
 
-               nodeoffset = fdt_path_offset (fdt, pathp);
+               nodeoffset = fdt_path_offset (working_fdt, pathp);
                if (nodeoffset < 0) {
                        /*
                         * Not found or something else bad happened.
@@ -171,16 +232,16 @@ int do_fdt (cmd_tbl_t * cmdtp, int flag, int argc, char *argv[])
                                fdt_strerror(nodeoffset));
                        return 1;
                }
-               err = fdt_add_subnode(fdt, nodeoffset, nodep);
+               err = fdt_add_subnode(working_fdt, nodeoffset, nodep);
                if (err < 0) {
                        printf ("libfdt fdt_add_subnode(): %s\n",
                                fdt_strerror(err));
                        return 1;
                }
 
-       /********************************************************************
-        * Set the value of a property in the fdt.
-        ********************************************************************/
+       /*
+        * Set the value of a property in the working_fdt.
+        */
        } else if (argv[1][0] == 's') {
                char *pathp;            /* path */
                char *prop;             /* property */
@@ -192,22 +253,20 @@ int do_fdt (cmd_tbl_t * cmdtp, int flag, int argc, char *argv[])
                /*
                 * Parameters: Node path, property, optional value.
                 */
-               if (argc < 4) {
-                       printf ("Usage:\n%s\n", cmdtp->usage);
-                       return 1;
-               }
+               if (argc < 4)
+                       return CMD_RET_USAGE;
 
                pathp  = argv[2];
                prop   = argv[3];
                if (argc == 4) {
                        len = 0;
                } else {
-                       ret = fdt_parse_prop(pathp, prop, argv[4], data, &len);
+                       ret = fdt_parse_prop(&argv[4], argc - 4, data, &len);
                        if (ret != 0)
                                return ret;
                }
 
-               nodeoffset = fdt_path_offset (fdt, pathp);
+               nodeoffset = fdt_path_offset (working_fdt, pathp);
                if (nodeoffset < 0) {
                        /*
                         * Not found or something else bad happened.
@@ -217,15 +276,126 @@ int do_fdt (cmd_tbl_t * cmdtp, int flag, int argc, char *argv[])
                        return 1;
                }
 
-               ret = fdt_setprop(fdt, nodeoffset, prop, data, len);
+               ret = fdt_setprop(working_fdt, nodeoffset, prop, data, len);
                if (ret < 0) {
                        printf ("libfdt fdt_setprop(): %s\n", fdt_strerror(ret));
                        return 1;
                }
 
        /********************************************************************
-        * Print (recursive) / List (single level)
+        * Get the value of a property in the working_fdt.
         ********************************************************************/
+       } else if (argv[1][0] == 'g') {
+               char *subcmd;           /* sub-command */
+               char *pathp;            /* path */
+               char *prop;             /* property */
+               char *var;              /* variable to store result */
+               int  nodeoffset;        /* node offset from libfdt */
+               const void *nodep;      /* property node pointer */
+               int  len = 0;           /* new length of the property */
+
+               /*
+                * Parameters: Node path, property, optional value.
+                */
+               if (argc < 5)
+                       return CMD_RET_USAGE;
+
+               subcmd = argv[2];
+
+               if (argc < 6 && subcmd[0] != 's')
+                       return CMD_RET_USAGE;
+
+               var    = argv[3];
+               pathp  = argv[4];
+               prop   = argv[5];
+
+               nodeoffset = fdt_path_offset(working_fdt, pathp);
+               if (nodeoffset < 0) {
+                       /*
+                        * Not found or something else bad happened.
+                        */
+                       printf("libfdt fdt_path_offset() returned %s\n",
+                               fdt_strerror(nodeoffset));
+                       return 1;
+               }
+
+               if (subcmd[0] == 'n' || (subcmd[0] == 's' && argc == 5)) {
+                       int reqIndex = -1;
+                       int startDepth = fdt_node_depth(
+                               working_fdt, nodeoffset);
+                       int curDepth = startDepth;
+                       int curIndex = -1;
+                       int nextNodeOffset = fdt_next_node(
+                               working_fdt, nodeoffset, &curDepth);
+
+                       if (subcmd[0] == 'n')
+                               reqIndex = simple_strtoul(argv[5], NULL, 16);
+
+                       while (curDepth > startDepth) {
+                               if (curDepth == startDepth + 1)
+                                       curIndex++;
+                               if (subcmd[0] == 'n' && curIndex == reqIndex) {
+                                       const char *nodeName = fdt_get_name(
+                                           working_fdt, nextNodeOffset, NULL);
+
+                                       setenv(var, (char *)nodeName);
+                                       return 0;
+                               }
+                               nextNodeOffset = fdt_next_node(
+                                       working_fdt, nextNodeOffset, &curDepth);
+                               if (nextNodeOffset < 0)
+                                       break;
+                       }
+                       if (subcmd[0] == 's') {
+                               /* get the num nodes at this level */
+                               char buf[11];
+
+                               sprintf(buf, "%d", curIndex + 1);
+                               setenv(var, buf);
+                       } else {
+                               /* node index not found */
+                               printf("libfdt node not found\n");
+                               return 1;
+                       }
+               } else {
+                       nodep = fdt_getprop(
+                               working_fdt, nodeoffset, prop, &len);
+                       if (len == 0) {
+                               /* no property value */
+                               setenv(var, "");
+                               return 0;
+                       } else if (len > 0) {
+                               if (subcmd[0] == 'v') {
+                                       int ret;
+
+                                       ret = fdt_value_setenv(nodep, len, var);
+                                       if (ret != 0)
+                                               return ret;
+                               } else if (subcmd[0] == 'a') {
+                                       /* Get address */
+                                       char buf[11];
+
+                                       sprintf(buf, "0x%p", nodep);
+                                       setenv(var, buf);
+                               } else if (subcmd[0] == 's') {
+                                       /* Get size */
+                                       char buf[11];
+
+                                       sprintf(buf, "0x%08X", len);
+                                       setenv(var, buf);
+                               } else
+                                       return CMD_RET_USAGE;
+                               return 0;
+                       } else {
+                               printf("libfdt fdt_getprop(): %s\n",
+                                       fdt_strerror(len));
+                               return 1;
+                       }
+               }
+
+       /*
+        * Print (recursive) / List (single level)
+        */
        } else if ((argv[1][0] == 'p') || (argv[1][0] == 'l')) {
                int depth = MAX_LEVEL;  /* how deep to print */
                char *pathp;            /* path */
@@ -257,10 +427,10 @@ int do_fdt (cmd_tbl_t * cmdtp, int flag, int argc, char *argv[])
                if (ret != 0)
                        return ret;
 
-       /********************************************************************
+       /*
         * Remove a property/node
-        ********************************************************************/
-       } else if ((argv[1][0] == 'r') && (argv[1][1] == 'm')) {
+        */
+       } else if (strncmp(argv[1], "rm", 2) == 0) {
                int  nodeoffset;        /* node offset from libfdt */
                int  err;
 
@@ -268,7 +438,7 @@ int do_fdt (cmd_tbl_t * cmdtp, int flag, int argc, char *argv[])
                 * Get the path.  The root node is an oddball, the offset
                 * is zero and has no name.
                 */
-               nodeoffset = fdt_path_offset (fdt, argv[2]);
+               nodeoffset = fdt_path_offset (working_fdt, argv[2]);
                if (nodeoffset < 0) {
                        /*
                         * Not found or something else bad happened.
@@ -282,14 +452,14 @@ int do_fdt (cmd_tbl_t * cmdtp, int flag, int argc, char *argv[])
                 * otherwise delete the node.
                 */
                if (argc > 3) {
-                       err = fdt_delprop(fdt, nodeoffset, argv[3]);
+                       err = fdt_delprop(working_fdt, nodeoffset, argv[3]);
                        if (err < 0) {
                                printf("libfdt fdt_delprop():  %s\n",
                                        fdt_strerror(err));
                                return err;
                        }
                } else {
-                       err = fdt_del_node(fdt, nodeoffset);
+                       err = fdt_del_node(working_fdt, nodeoffset);
                        if (err < 0) {
                                printf("libfdt fdt_del_node():  %s\n",
                                        fdt_strerror(err));
@@ -297,68 +467,68 @@ int do_fdt (cmd_tbl_t * cmdtp, int flag, int argc, char *argv[])
                        }
                }
 
-       /********************************************************************
+       /*
         * Display header info
-        ********************************************************************/
+        */
        } else if (argv[1][0] == 'h') {
-               u32 version = fdt_version(fdt);
-               printf("magic:\t\t\t0x%x\n", fdt_magic(fdt));
-               printf("totalsize:\t\t0x%x (%d)\n", fdt_totalsize(fdt), fdt_totalsize(fdt));
-               printf("off_dt_struct:\t\t0x%x\n", fdt_off_dt_struct(fdt));
-               printf("off_dt_strings:\t\t0x%x\n", fdt_off_dt_strings(fdt));
-               printf("off_mem_rsvmap:\t\t0x%x\n", fdt_off_mem_rsvmap(fdt));
+               u32 version = fdt_version(working_fdt);
+               printf("magic:\t\t\t0x%x\n", fdt_magic(working_fdt));
+               printf("totalsize:\t\t0x%x (%d)\n", fdt_totalsize(working_fdt),
+                      fdt_totalsize(working_fdt));
+               printf("off_dt_struct:\t\t0x%x\n",
+                      fdt_off_dt_struct(working_fdt));
+               printf("off_dt_strings:\t\t0x%x\n",
+                      fdt_off_dt_strings(working_fdt));
+               printf("off_mem_rsvmap:\t\t0x%x\n",
+                      fdt_off_mem_rsvmap(working_fdt));
                printf("version:\t\t%d\n", version);
-               printf("last_comp_version:\t%d\n", fdt_last_comp_version(fdt));
+               printf("last_comp_version:\t%d\n",
+                      fdt_last_comp_version(working_fdt));
                if (version >= 2)
                        printf("boot_cpuid_phys:\t0x%x\n",
-                               fdt_boot_cpuid_phys(fdt));
+                               fdt_boot_cpuid_phys(working_fdt));
                if (version >= 3)
                        printf("size_dt_strings:\t0x%x\n",
-                               fdt_size_dt_strings(fdt));
+                               fdt_size_dt_strings(working_fdt));
                if (version >= 17)
                        printf("size_dt_struct:\t\t0x%x\n",
-                               fdt_size_dt_struct(fdt));
-               printf("number mem_rsv:\t\t0x%x\n", fdt_num_mem_rsv(fdt));
+                               fdt_size_dt_struct(working_fdt));
+               printf("number mem_rsv:\t\t0x%x\n",
+                      fdt_num_mem_rsv(working_fdt));
                printf("\n");
 
-       /********************************************************************
+       /*
         * Set boot cpu id
-        ********************************************************************/
-       } else if ((argv[1][0] == 'b') && (argv[1][1] == 'o') &&
-                  (argv[1][2] == 'o')) {
+        */
+       } else if (strncmp(argv[1], "boo", 3) == 0) {
                unsigned long tmp = simple_strtoul(argv[2], NULL, 16);
-               fdt_set_boot_cpuid_phys(fdt, tmp);
+               fdt_set_boot_cpuid_phys(working_fdt, tmp);
 
-       /********************************************************************
+       /*
         * memory command
-        ********************************************************************/
-       } else if ((argv[1][0] == 'm') && (argv[1][1] == 'e')) {
+        */
+       } else if (strncmp(argv[1], "me", 2) == 0) {
                uint64_t addr, size;
                int err;
-#ifdef CFG_64BIT_STRTOUL
-                       addr = simple_strtoull(argv[2], NULL, 16);
-                       size = simple_strtoull(argv[3], NULL, 16);
-#else
-                       addr = simple_strtoul(argv[2], NULL, 16);
-                       size = simple_strtoul(argv[3], NULL, 16);
-#endif
-               err = fdt_fixup_memory(fdt, addr, size);
+               addr = simple_strtoull(argv[2], NULL, 16);
+               size = simple_strtoull(argv[3], NULL, 16);
+               err = fdt_fixup_memory(working_fdt, addr, size);
                if (err < 0)
                        return err;
 
-       /********************************************************************
+       /*
         * mem reserve commands
-        ********************************************************************/
-       } else if ((argv[1][0] == 'r') && (argv[1][1] == 's')) {
+        */
+       } else if (strncmp(argv[1], "rs", 2) == 0) {
                if (argv[2][0] == 'p') {
                        uint64_t addr, size;
-                       int total = fdt_num_mem_rsv(fdt);
+                       int total = fdt_num_mem_rsv(working_fdt);
                        int j, err;
                        printf("index\t\t   start\t\t    size\n");
                        printf("-------------------------------"
                                "-----------------\n");
                        for (j = 0; j < total; j++) {
-                               err = fdt_get_mem_rsv(fdt, j, &addr, &size);
+                               err = fdt_get_mem_rsv(working_fdt, j, &addr, &size);
                                if (err < 0) {
                                        printf("libfdt fdt_get_mem_rsv():  %s\n",
                                                        fdt_strerror(err));
@@ -373,14 +543,9 @@ int do_fdt (cmd_tbl_t * cmdtp, int flag, int argc, char *argv[])
                } else if (argv[2][0] == 'a') {
                        uint64_t addr, size;
                        int err;
-#ifdef CFG_64BIT_STRTOUL
                        addr = simple_strtoull(argv[3], NULL, 16);
                        size = simple_strtoull(argv[4], NULL, 16);
-#else
-                       addr = simple_strtoul(argv[3], NULL, 16);
-                       size = simple_strtoul(argv[4], NULL, 16);
-#endif
-                       err = fdt_add_mem_rsv(fdt, addr, size);
+                       err = fdt_add_mem_rsv(working_fdt, addr, size);
 
                        if (err < 0) {
                                printf("libfdt fdt_add_mem_rsv():  %s\n",
@@ -389,7 +554,7 @@ int do_fdt (cmd_tbl_t * cmdtp, int flag, int argc, char *argv[])
                        }
                } else if (argv[2][0] == 'd') {
                        unsigned long idx = simple_strtoul(argv[3], NULL, 16);
-                       int err = fdt_del_mem_rsv(fdt, idx);
+                       int err = fdt_del_mem_rsv(working_fdt, idx);
 
                        if (err < 0) {
                                printf("libfdt fdt_del_mem_rsv():  %s\n",
@@ -398,33 +563,36 @@ int do_fdt (cmd_tbl_t * cmdtp, int flag, int argc, char *argv[])
                        }
                } else {
                        /* Unrecognized command */
-                       printf ("Usage:\n%s\n", cmdtp->usage);
-                       return 1;
+                       return CMD_RET_USAGE;
                }
        }
 #ifdef CONFIG_OF_BOARD_SETUP
        /* Call the board-specific fixup routine */
-       else if (argv[1][0] == 'b')
-               ft_board_setup(fdt, gd->bd);
+       else if (strncmp(argv[1], "boa", 3) == 0)
+               ft_board_setup(working_fdt, gd->bd);
 #endif
        /* Create a chosen node */
-       else if (argv[1][0] == 'c')
-               fdt_chosen(fdt, 0, 0, 1);
+       else if (argv[1][0] == 'c') {
+               unsigned long initrd_start = 0, initrd_end = 0;
 
-#ifdef CONFIG_OF_HAS_UBOOT_ENV
-       /* Create a u-boot-env node */
-       else if (argv[1][0] == 'e')
-               fdt_env(fdt);
-#endif
-#ifdef CONFIG_OF_HAS_BD_T
-       /* Create a bd_t node */
-       else if (argv[1][0] == 'b')
-               fdt_bd_t(fdt);
-#endif
+               if ((argc != 2) && (argc != 4))
+                       return CMD_RET_USAGE;
+
+               if (argc == 4) {
+                       initrd_start = simple_strtoul(argv[2], NULL, 16);
+                       initrd_end = simple_strtoul(argv[3], NULL, 16);
+               }
+
+               fdt_chosen(working_fdt, 1);
+               fdt_initrd(working_fdt, initrd_start, initrd_end, 1);
+       }
+       /* resize the fdt */
+       else if (strncmp(argv[1], "re", 2) == 0) {
+               fdt_resize(working_fdt);
+       }
        else {
                /* Unrecognized command */
-               printf ("Usage:\n%s\n", cmdtp->usage);
-               return 1;
+               return CMD_RET_USAGE;
        }
 
        return 0;
@@ -436,12 +604,12 @@ static int fdt_valid(void)
 {
        int  err;
 
-       if (fdt == NULL) {
+       if (working_fdt == NULL) {
                printf ("The address of the fdt is invalid (NULL).\n");
                return 0;
        }
 
-       err = fdt_check_header(fdt);
+       err = fdt_check_header(working_fdt);
        if (err == 0)
                return 1;       /* valid */
 
@@ -451,17 +619,19 @@ static int fdt_valid(void)
                 * Be more informative on bad version.
                 */
                if (err == -FDT_ERR_BADVERSION) {
-                       if (fdt_version(fdt) < FDT_FIRST_SUPPORTED_VERSION) {
-                               printf (" - too old, fdt $d < %d",
-                                       fdt_version(fdt),
+                       if (fdt_version(working_fdt) <
+                           FDT_FIRST_SUPPORTED_VERSION) {
+                               printf (" - too old, fdt %d < %d",
+                                       fdt_version(working_fdt),
                                        FDT_FIRST_SUPPORTED_VERSION);
-                               fdt = NULL;
+                               working_fdt = NULL;
                        }
-                       if (fdt_last_comp_version(fdt) > FDT_LAST_SUPPORTED_VERSION) {
-                               printf (" - too new, fdt $d > %d",
-                                       fdt_version(fdt),
+                       if (fdt_last_comp_version(working_fdt) >
+                           FDT_LAST_SUPPORTED_VERSION) {
+                               printf (" - too new, fdt %d > %d",
+                                       fdt_version(working_fdt),
                                        FDT_LAST_SUPPORTED_VERSION);
-                               fdt = NULL;
+                               working_fdt = NULL;
                        }
                        return 0;
                }
@@ -475,79 +645,97 @@ static int fdt_valid(void)
 
 /*
  * Parse the user's input, partially heuristic.  Valid formats:
- * <00>                - hex byte
- * <0011>      - hex half word (16 bits)
- * <00112233>  - hex word (32 bits)
- *             - hex double words (64 bits) are not supported, must use
- *                     a byte stream instead.
+ * <0x00112233 4 05>   - an array of cells.  Numbers follow standard
+ *                     C conventions.
  * [00 11 22 .. nn] - byte stream
  * "string"    - If the the value doesn't start with "<" or "[", it is
  *                     treated as a string.  Note that the quotes are
  *                     stripped by the parser before we get the string.
+ * newval: An array of strings containing the new property as specified
+ *     on the command line
+ * count: The number of strings in the array
+ * data: A bytestream to be placed in the property
+ * len: The length of the resulting bytestream
  */
-static int fdt_parse_prop(char *pathp, char *prop, char *newval,
-       char *data, int *len)
+static int fdt_parse_prop(char * const *newval, int count, char *data, int *len)
 {
        char *cp;               /* temporary char pointer */
+       char *newp;             /* temporary newval char pointer */
        unsigned long tmp;      /* holds converted values */
+       int stridx = 0;
 
-       if (*newval == '<') {
-               /*
-                * Bigger values than bytes.
-                */
-               *len = 0;
-               newval++;
-               while ((*newval != '>') && (*newval != '\0')) {
-                       cp = newval;
-                       tmp = simple_strtoul(cp, &newval, 16);
-                       if ((newval - cp) <= 2) {
-                               *data = tmp & 0xFF;
-                               data  += 1;
-                               *len += 1;
-                       } else if ((newval - cp) <= 4) {
-                               *(uint16_t *)data = __cpu_to_be16(tmp);
-                               data  += 2;
-                               *len += 2;
-                       } else if ((newval - cp) <= 8) {
-                               *(uint32_t *)data = __cpu_to_be32(tmp);
-                               data  += 4;
-                               *len += 4;
-                       } else {
+       *len = 0;
+       newp = newval[0];
+
+       /* An array of cells */
+       if (*newp == '<') {
+               newp++;
+               while ((*newp != '>') && (stridx < count)) {
+                       /*
+                        * Keep searching until we find that last ">"
+                        * That way users don't have to escape the spaces
+                        */
+                       if (*newp == '\0') {
+                               newp = newval[++stridx];
+                               continue;
+                       }
+
+                       cp = newp;
+                       tmp = simple_strtoul(cp, &newp, 0);
+                       *(__be32 *)data = __cpu_to_be32(tmp);
+                       data  += 4;
+                       *len += 4;
+
+                       /* If the ptr didn't advance, something went wrong */
+                       if ((newp - cp) <= 0) {
                                printf("Sorry, I could not convert \"%s\"\n",
                                        cp);
                                return 1;
                        }
-                       while (*newval == ' ')
-                               newval++;
+
+                       while (*newp == ' ')
+                               newp++;
                }
-               if (*newval != '>') {
-                       printf("Unexpected character '%c'\n", *newval);
+
+               if (*newp != '>') {
+                       printf("Unexpected character '%c'\n", *newp);
                        return 1;
                }
-       } else if (*newval == '[') {
+       } else if (*newp == '[') {
                /*
                 * Byte stream.  Convert the values.
                 */
-               *len = 0;
-               newval++;
-               while ((*newval != ']') && (*newval != '\0')) {
-                       tmp = simple_strtoul(newval, &newval, 16);
+               newp++;
+               while ((stridx < count) && (*newp != ']')) {
+                       while (*newp == ' ')
+                               newp++;
+                       if (*newp == '\0') {
+                               newp = newval[++stridx];
+                               continue;
+                       }
+                       if (!isxdigit(*newp))
+                               break;
+                       tmp = simple_strtoul(newp, &newp, 16);
                        *data++ = tmp & 0xFF;
                        *len    = *len + 1;
-                       while (*newval == ' ')
-                               newval++;
                }
-               if (*newval != ']') {
-                       printf("Unexpected character '%c'\n", *newval);
+               if (*newp != ']') {
+                       printf("Unexpected character '%c'\n", *newp);
                        return 1;
                }
        } else {
                /*
-                * Assume it is a string.  Copy it into our data area for
-                * convenience (including the terminating '\0').
+                * Assume it is one or more strings.  Copy it into our
+                * data area for convenience (including the
+                * terminating '\0's).
                 */
-               *len = strlen(newval) + 1;
-               strcpy(data, newval);
+               while (stridx < count) {
+                       size_t length = strlen(newp) + 1;
+                       strcpy(data, newp);
+                       data += length;
+                       *len += length;
+                       newp = newval[++stridx];
+               }
        }
        return 0;
 }
@@ -566,12 +754,12 @@ static int is_printable_string(const void *data, int len)
        if (len == 0)
                return 0;
 
-       /* must terminate with zero */
-       if (s[len - 1] != '\0')
+       /* must terminate with zero or '\n' */
+       if (s[len - 1] != '\0' && s[len - 1] != '\n')
                return 0;
 
        /* printable or a null byte (concatenated strings) */
-       while (((*s == '\0') || isprint(*s)) && (len > 0)) {
+       while (((*s == '\0') || isprint(*s) || isspace(*s)) && (len > 0)) {
                /*
                 * If we see a null, there are three possibilities:
                 * 1) If len == 1, it is the end of the string, printable
@@ -604,7 +792,6 @@ static int is_printable_string(const void *data, int len)
 static void print_data(const void *data, int len)
 {
        int j;
-       const u8 *s;
 
        /* no data, don't print */
        if (len == 0)
@@ -627,39 +814,36 @@ static void print_data(const void *data, int len)
                return;
        }
 
-       switch (len) {
-       case 1:  /* byte */
-               printf("<0x%02x>", (*(u8 *) data) & 0xff);
-               break;
-       case 2:  /* half-word */
-               printf("<0x%04x>", be16_to_cpu(*(u16 *) data) & 0xffff);
-               break;
-       case 4:  /* word */
-               printf("<0x%08x>", be32_to_cpu(*(u32 *) data) & 0xffffffffU);
-               break;
-       case 8:  /* double-word */
-#if __WORDSIZE == 64
-               printf("<0x%016llx>", be64_to_cpu(*(uint64_t *) data));
-#else
-               printf("<0x%08x ", be32_to_cpu(*(u32 *) data) & 0xffffffffU);
-               data += 4;
-               printf("0x%08x>", be32_to_cpu(*(u32 *) data) & 0xffffffffU);
-#endif
-               break;
-       default:                /* anything else... hexdump */
-               printf("[");
-               for (j = 0, s = data; j < len; j++)
-                       printf("%02x%s", s[j], j < len - 1 ? " " : "");
-               printf("]");
-
-               break;
+       if ((len %4) == 0) {
+               if (len > CONFIG_CMD_FDT_MAX_DUMP)
+                       printf("* 0x%p [0x%08x]", data, len);
+               else {
+                       const __be32 *p;
+
+                       printf("<");
+                       for (j = 0, p = data; j < len/4; j++)
+                               printf("0x%08x%s", fdt32_to_cpu(p[j]),
+                                       j < (len/4 - 1) ? " " : "");
+                       printf(">");
+               }
+       } else { /* anything else... hexdump */
+               if (len > CONFIG_CMD_FDT_MAX_DUMP)
+                       printf("* 0x%p [0x%08x]", data, len);
+               else {
+                       const u8 *s;
+
+                       printf("[");
+                       for (j = 0, s = data; j < len; j++)
+                               printf("%02x%s", s[j], j < len - 1 ? " " : "");
+                       printf("]");
+               }
        }
 }
 
 /****************************************************************************/
 
 /*
- * Recursively print (a portion of) the fdt.  The depth parameter
+ * Recursively print (a portion of) the working_fdt.  The depth parameter
  * determines how deeply nested the fdt is printed.
  */
 static int fdt_print(const char *pathp, char *prop, int depth)
@@ -675,7 +859,7 @@ static int fdt_print(const char *pathp, char *prop, int depth)
        int  level = 0;         /* keep track of nesting level */
        const struct fdt_property *fdt_prop;
 
-       nodeoffset = fdt_path_offset (fdt, pathp);
+       nodeoffset = fdt_path_offset (working_fdt, pathp);
        if (nodeoffset < 0) {
                /*
                 * Not found or something else bad happened.
@@ -689,7 +873,7 @@ static int fdt_print(const char *pathp, char *prop, int depth)
         * Print only the given property and then return.
         */
        if (prop) {
-               nodep = fdt_getprop (fdt, nodeoffset, prop, &len);
+               nodep = fdt_getprop (working_fdt, nodeoffset, prop, &len);
                if (len == 0) {
                        /* no property value */
                        printf("%s %s\n", pathp, prop);
@@ -711,10 +895,10 @@ static int fdt_print(const char *pathp, char *prop, int depth)
         * print the node and all subnodes.
         */
        while(level >= 0) {
-               tag = fdt_next_tag(fdt, nodeoffset, &nextoffset);
+               tag = fdt_next_tag(working_fdt, nodeoffset, &nextoffset);
                switch(tag) {
                case FDT_BEGIN_NODE:
-                       pathp = fdt_get_name(fdt, nodeoffset, NULL);
+                       pathp = fdt_get_name(working_fdt, nodeoffset, NULL);
                        if (level <= depth) {
                                if (pathp == NULL)
                                        pathp = "/* NULL pointer error */";
@@ -738,9 +922,9 @@ static int fdt_print(const char *pathp, char *prop, int depth)
                        }
                        break;
                case FDT_PROP:
-                       fdt_prop = fdt_offset_ptr(fdt, nodeoffset,
+                       fdt_prop = fdt_offset_ptr(working_fdt, nodeoffset,
                                        sizeof(*fdt_prop));
-                       pathp    = fdt_string(fdt,
+                       pathp    = fdt_string(working_fdt,
                                        fdt32_to_cpu(fdt_prop->nameoff));
                        len      = fdt32_to_cpu(fdt_prop->len);
                        nodep    = fdt_prop->data;
@@ -765,7 +949,7 @@ static int fdt_print(const char *pathp, char *prop, int depth)
                        }
                        break;
                case FDT_NOP:
-                       printf("/* NOP */\n", &tabs[MAX_LEVEL - level]);
+                       printf("%s/* NOP */\n", &tabs[MAX_LEVEL - level]);
                        break;
                case FDT_END:
                        return 1;
@@ -780,17 +964,20 @@ static int fdt_print(const char *pathp, char *prop, int depth)
 }
 
 /********************************************************************/
-
-U_BOOT_CMD(
-       fdt,    5,      0,      do_fdt,
-       "fdt     - flattened device tree utility commands\n",
-           "addr   <addr> [<length>]        - Set the fdt location to <addr>\n"
+#ifdef CONFIG_SYS_LONGHELP
+static char fdt_help_text[] =
+       "addr   <addr> [<length>]        - Set the fdt location to <addr>\n"
 #ifdef CONFIG_OF_BOARD_SETUP
        "fdt boardsetup                      - Do board-specific set up\n"
 #endif
        "fdt move   <fdt> <newaddr> <length> - Copy the fdt to <addr> and make it active\n"
+       "fdt resize                          - Resize fdt to size + padding to 4k addr\n"
        "fdt print  <path> [<prop>]          - Recursive print starting at <path>\n"
        "fdt list   <path> [<prop>]          - Print one level starting at <path>\n"
+       "fdt get value <var> <path> <prop>   - Get <property> and store in <var>\n"
+       "fdt get name <var> <path> <index>   - Get name of node <index> and store in <var>\n"
+       "fdt get addr <var> <path> <prop>    - Get start address of <property> and store in <var>\n"
+       "fdt get size <var> <path> [<prop>]  - Get size of [<property>] or num nodes and store in <var>\n"
        "fdt set    <path> <prop> [<val>]    - Set <property> [to <val>]\n"
        "fdt mknode <path> <node>            - Create a new node after <path>\n"
        "fdt rm     <path> [<prop>]          - Delete the node or <property>\n"
@@ -800,13 +987,13 @@ U_BOOT_CMD(
        "fdt rsvmem print                    - Show current mem reserves\n"
        "fdt rsvmem add <addr> <size>        - Add a mem reserve\n"
        "fdt rsvmem delete <index>           - Delete a mem reserves\n"
-       "fdt chosen - Add/update the /chosen branch in the tree\n"
-#ifdef CONFIG_OF_HAS_UBOOT_ENV
-       "fdt env    - Add/replace the /u-boot-env branch in the tree\n"
-#endif
-#ifdef CONFIG_OF_HAS_BD_T
-       "fdt bd_t   - Add/replace the /bd_t branch in the tree\n"
+       "fdt chosen [<start> <end>]          - Add/update the /chosen branch in the tree\n"
+       "                                        <start>/<end> - initrd start/end addr\n"
+       "NOTE: Dereference aliases by omiting the leading '/', "
+               "e.g. fdt print ethernet0.";
 #endif
-       "NOTE: If the path or property you are setting/printing has a '#' character\n"
-       "     or spaces, you MUST escape it with a \\ character or quote it with \".\n"
+
+U_BOOT_CMD(
+       fdt,    255,    0,      do_fdt,
+       "flattened device tree utility commands", fdt_help_text
 );