]> git.kernelconcepts.de Git - karo-tx-uboot.git/blobdiff - common/usb_storage.c
usb: Optimize USB storage read/write
[karo-tx-uboot.git] / common / usb_storage.c
index 10e786fa95195bf8977cac03bb1050f29ea91702..4aeed827c1e60e624e2ec81857a5cf37ce6e8047 100644 (file)
@@ -79,8 +79,7 @@ static const unsigned char us_direction[256/8] = {
 };
 #define US_DIRECTION(x) ((us_direction[x>>3] >> (x & 7)) & 1)
 
-static unsigned char usb_stor_buf[512];
-static ccb usb_ccb;
+static ccb usb_ccb __attribute__((aligned(ARCH_DMA_MINALIGN)));
 
 /*
  * CBI style
@@ -137,6 +136,7 @@ struct us_data {
        struct usb_device *pusb_dev;     /* this usb_device */
 
        unsigned int    flags;                  /* from filter initially */
+#      define USB_READY        (1 << 0)
        unsigned char   ifnum;                  /* interface number */
        unsigned char   ep_in;                  /* in endpoint */
        unsigned char   ep_out;                 /* out ....... */
@@ -156,6 +156,17 @@ struct us_data {
        trans_cmnd      transport;              /* transport routine */
 };
 
+#ifdef CONFIG_USB_EHCI
+/*
+ * The U-Boot EHCI driver can handle any transfer length as long as there is
+ * enough free heap space left, but the SCSI READ(10) and WRITE(10) commands are
+ * limited to 65535 blocks.
+ */
+#define USB_MAX_XFER_BLK       65535
+#else
+#define USB_MAX_XFER_BLK       20
+#endif
+
 static struct us_data usb_stor[USB_MAX_STOR_DEV];
 
 
@@ -209,17 +220,17 @@ int usb_stor_info(void)
 static unsigned int usb_get_max_lun(struct us_data *us)
 {
        int len;
-       unsigned char result;
+       ALLOC_CACHE_ALIGN_BUFFER(unsigned char, result, 1);
        len = usb_control_msg(us->pusb_dev,
                              usb_rcvctrlpipe(us->pusb_dev, 0),
                              US_BBB_GET_MAX_LUN,
                              USB_TYPE_CLASS | USB_RECIP_INTERFACE | USB_DIR_IN,
                              0, us->ifnum,
-                             &result, sizeof(result),
+                             result, sizeof(char),
                              USB_CNTL_TIMEOUT * 5);
        USB_STOR_PRINTF("Get Max LUN -> len = %i, result = %i\n",
-                       len, (int) result);
-       return (len > 0) ? result : 0;
+                       len, (int) *result);
+       return (len > 0) ? *result : 0;
 }
 
 /*******************************************************************************
@@ -232,9 +243,6 @@ int usb_stor_scan(int mode)
        unsigned char i;
        struct usb_device *dev;
 
-       /* GJ */
-       memset(usb_stor_buf, 0, sizeof(usb_stor_buf));
-
        if (mode == 1)
                printf("       scanning bus for storage devices... ");
 
@@ -373,7 +381,7 @@ static int us_one_transfer(struct us_data *us, int pipe, char *buf, int length)
                                        usb_clear_halt(us->pusb_dev, pipe);
                                        us->pusb_dev->status = stat;
                                        if (this_xfer == partial) {
-                                               USB_STOR_PRINTF("bulk transferred with error %X, but data ok\n", us->pusb_dev->status);
+                                               USB_STOR_PRINTF("bulk transferred with error %lX, but data ok\n", us->pusb_dev->status);
                                                return 0;
                                        }
                                        else
@@ -385,12 +393,12 @@ static int us_one_transfer(struct us_data *us, int pipe, char *buf, int length)
                                }
                                USB_STOR_PRINTF("bulk transferred with error");
                                if (this_xfer == partial) {
-                                       USB_STOR_PRINTF(" %d, but data ok\n",
+                                       USB_STOR_PRINTF(" %ld, but data ok\n",
                                                        us->pusb_dev->status);
                                        return 0;
                                }
                                /* if our try counter reaches 0, bail out */
-                                       USB_STOR_PRINTF(" %d, data %d\n",
+                                       USB_STOR_PRINTF(" %ld, data %d\n",
                                                us->pusb_dev->status, partial);
                                if (!maxtry--)
                                                return result;
@@ -437,20 +445,20 @@ static int usb_stor_BBB_reset(struct us_data *us)
        }
 
        /* long wait for reset */
-       wait_ms(150);
-       USB_STOR_PRINTF("BBB_reset result %d: status %X reset\n", result,
+       mdelay(150);
+       USB_STOR_PRINTF("BBB_reset result %d: status %lX reset\n", result,
                        us->pusb_dev->status);
        pipe = usb_rcvbulkpipe(us->pusb_dev, us->ep_in);
        result = usb_clear_halt(us->pusb_dev, pipe);
        /* long wait for reset */
-       wait_ms(150);
-       USB_STOR_PRINTF("BBB_reset result %d: status %X clearing IN endpoint\n",
+       mdelay(150);
+       USB_STOR_PRINTF("BBB_reset result %d: status %lX clearing IN endpoint\n",
                        result, us->pusb_dev->status);
        /* long wait for reset */
        pipe = usb_sndbulkpipe(us->pusb_dev, us->ep_out);
        result = usb_clear_halt(us->pusb_dev, pipe);
-       wait_ms(150);
-       USB_STOR_PRINTF("BBB_reset result %d: status %X"
+       mdelay(150);
+       USB_STOR_PRINTF("BBB_reset result %d: status %lX"
                        " clearing OUT endpoint\n", result,
                        us->pusb_dev->status);
        USB_STOR_PRINTF("BBB_reset done\n");
@@ -477,8 +485,8 @@ static int usb_stor_CB_reset(struct us_data *us)
                                 USB_CNTL_TIMEOUT * 5);
 
        /* long wait for reset */
-       wait_ms(1500);
-       USB_STOR_PRINTF("CB_reset result %d: status %X"
+       mdelay(1500);
+       USB_STOR_PRINTF("CB_reset result %d: status %lX"
                        " clearing endpoint halt\n", result,
                        us->pusb_dev->status);
        usb_clear_halt(us->pusb_dev, usb_rcvbulkpipe(us->pusb_dev, us->ep_in));
@@ -498,7 +506,7 @@ int usb_stor_BBB_comdat(ccb *srb, struct us_data *us)
        int actlen;
        int dir_in;
        unsigned int pipe;
-       umass_bbb_cbw_t cbw;
+       ALLOC_CACHE_ALIGN_BUFFER(umass_bbb_cbw_t, cbw, 1);
 
        dir_in = US_DIRECTION(srb->cmd[0]);
 
@@ -521,16 +529,16 @@ int usb_stor_BBB_comdat(ccb *srb, struct us_data *us)
        /* always OUT to the ep */
        pipe = usb_sndbulkpipe(us->pusb_dev, us->ep_out);
 
-       cbw.dCBWSignature = cpu_to_le32(CBWSIGNATURE);
-       cbw.dCBWTag = cpu_to_le32(CBWTag++);
-       cbw.dCBWDataTransferLength = cpu_to_le32(srb->datalen);
-       cbw.bCBWFlags = (dir_in ? CBWFLAGS_IN : CBWFLAGS_OUT);
-       cbw.bCBWLUN = srb->lun;
-       cbw.bCDBLength = srb->cmdlen;
+       cbw->dCBWSignature = cpu_to_le32(CBWSIGNATURE);
+       cbw->dCBWTag = cpu_to_le32(CBWTag++);
+       cbw->dCBWDataTransferLength = cpu_to_le32(srb->datalen);
+       cbw->bCBWFlags = (dir_in ? CBWFLAGS_IN : CBWFLAGS_OUT);
+       cbw->bCBWLUN = srb->lun;
+       cbw->bCDBLength = srb->cmdlen;
        /* copy the command data into the CBW command data buffer */
        /* DST SRC LEN!!! */
-       memcpy(cbw.CBWCDB, srb->cmd, srb->cmdlen);
-       result = usb_bulk_msg(us->pusb_dev, pipe, &cbw, UMASS_BBB_CBW_SIZE,
+       memcpy(cbw->CBWCDB, srb->cmd, srb->cmdlen);
+       result = usb_bulk_msg(us->pusb_dev, pipe, cbw, UMASS_BBB_CBW_SIZE,
                              &actlen, USB_CNTL_TIMEOUT * 5);
        if (result < 0)
                USB_STOR_PRINTF("usb_stor_BBB_comdat:usb_bulk_msg error\n");
@@ -569,7 +577,7 @@ int usb_stor_CB_comdat(ccb *srb, struct us_data *us)
                                         srb->cmd, srb->cmdlen,
                                         USB_CNTL_TIMEOUT * 5);
                USB_STOR_PRINTF("CB_transport: control msg returned %d,"
-                               " status %X\n", result, us->pusb_dev->status);
+                               " status %lX\n", result, us->pusb_dev->status);
                /* check the return code for the command */
                if (result < 0) {
                        if (us->pusb_dev->status & USB_ST_STALLED) {
@@ -581,7 +589,7 @@ int usb_stor_CB_comdat(ccb *srb, struct us_data *us)
                                us->pusb_dev->status = status;
                        }
                        USB_STOR_PRINTF(" error during command %02X"
-                                       " Stat = %X\n", srb->cmd[0],
+                                       " Stat = %lX\n", srb->cmd[0],
                                        us->pusb_dev->status);
                        return result;
                }
@@ -620,7 +628,7 @@ int usb_stor_CBI_get_status(ccb *srb, struct us_data *us)
        while (timeout--) {
                if ((volatile int *) us->ip_wanted == 0)
                        break;
-               wait_ms(10);
+               mdelay(10);
        }
        if (us->ip_wanted) {
                printf("        Did not get interrupt on CBI\n");
@@ -674,7 +682,7 @@ int usb_stor_BBB_transport(ccb *srb, struct us_data *us)
        int dir_in;
        int actlen, data_actlen;
        unsigned int pipe, pipein, pipeout;
-       umass_bbb_csw_t csw;
+       ALLOC_CACHE_ALIGN_BUFFER(umass_bbb_csw_t, csw, 1);
 #ifdef BBB_XPORT_TRACE
        unsigned char *ptr;
        int index;
@@ -691,7 +699,8 @@ int usb_stor_BBB_transport(ccb *srb, struct us_data *us)
                usb_stor_BBB_reset(us);
                return USB_STOR_TRANSPORT_FAILED;
        }
-       wait_ms(5);
+       if (!(us->flags & USB_READY))
+               mdelay(5);
        pipein = usb_rcvbulkpipe(us->pusb_dev, us->ep_in);
        pipeout = usb_sndbulkpipe(us->pusb_dev, us->ep_out);
        /* DATA phase + error handling */
@@ -732,7 +741,7 @@ st:
        retry = 0;
 again:
        USB_STOR_PRINTF("STATUS phase\n");
-       result = usb_bulk_msg(us->pusb_dev, pipein, &csw, UMASS_BBB_CSW_SIZE,
+       result = usb_bulk_msg(us->pusb_dev, pipein, csw, UMASS_BBB_CSW_SIZE,
                                &actlen, USB_CNTL_TIMEOUT*5);
 
        /* special handling of STALL in STATUS phase */
@@ -752,36 +761,36 @@ again:
                return USB_STOR_TRANSPORT_FAILED;
        }
 #ifdef BBB_XPORT_TRACE
-       ptr = (unsigned char *)&csw;
+       ptr = (unsigned char *)csw;
        for (index = 0; index < UMASS_BBB_CSW_SIZE; index++)
                printf("ptr[%d] %#x ", index, ptr[index]);
        printf("\n");
 #endif
        /* misuse pipe to get the residue */
-       pipe = le32_to_cpu(csw.dCSWDataResidue);
+       pipe = le32_to_cpu(csw->dCSWDataResidue);
        if (pipe == 0 && srb->datalen != 0 && srb->datalen - data_actlen != 0)
                pipe = srb->datalen - data_actlen;
-       if (CSWSIGNATURE != le32_to_cpu(csw.dCSWSignature)) {
+       if (CSWSIGNATURE != le32_to_cpu(csw->dCSWSignature)) {
                USB_STOR_PRINTF("!CSWSIGNATURE\n");
                usb_stor_BBB_reset(us);
                return USB_STOR_TRANSPORT_FAILED;
-       } else if ((CBWTag - 1) != le32_to_cpu(csw.dCSWTag)) {
+       } else if ((CBWTag - 1) != le32_to_cpu(csw->dCSWTag)) {
                USB_STOR_PRINTF("!Tag\n");
                usb_stor_BBB_reset(us);
                return USB_STOR_TRANSPORT_FAILED;
-       } else if (csw.bCSWStatus > CSWSTATUS_PHASE) {
+       } else if (csw->bCSWStatus > CSWSTATUS_PHASE) {
                USB_STOR_PRINTF(">PHASE\n");
                usb_stor_BBB_reset(us);
                return USB_STOR_TRANSPORT_FAILED;
-       } else if (csw.bCSWStatus == CSWSTATUS_PHASE) {
+       } else if (csw->bCSWStatus == CSWSTATUS_PHASE) {
                USB_STOR_PRINTF("=PHASE\n");
                usb_stor_BBB_reset(us);
                return USB_STOR_TRANSPORT_FAILED;
        } else if (data_actlen > srb->datalen) {
-               USB_STOR_PRINTF("transferred %dB instead of %dB\n",
+               USB_STOR_PRINTF("transferred %dB instead of %ldB\n",
                        data_actlen, srb->datalen);
                return USB_STOR_TRANSPORT_FAILED;
-       } else if (csw.bCSWStatus == CSWSTATUS_FAILED) {
+       } else if (csw->bCSWStatus == CSWSTATUS_FAILED) {
                USB_STOR_PRINTF("FAILED\n");
                return USB_STOR_TRANSPORT_FAILED;
        }
@@ -803,7 +812,7 @@ int usb_stor_CB_transport(ccb *srb, struct us_data *us)
        /* issue the command */
 do_retry:
        result = usb_stor_CB_comdat(srb, us);
-       USB_STOR_PRINTF("command / Data returned %d, status %X\n",
+       USB_STOR_PRINTF("command / Data returned %d, status %lX\n",
                        result, us->pusb_dev->status);
        /* if this is an CBI Protocol, get IRQ */
        if (us->protocol == US_PR_CBI) {
@@ -826,7 +835,7 @@ do_retry:
        /* do we have to issue an auto request? */
        /* HERE we have to check the result */
        if ((result < 0) && !(us->pusb_dev->status & USB_ST_STALLED)) {
-               USB_STOR_PRINTF("ERROR %X\n", us->pusb_dev->status);
+               USB_STOR_PRINTF("ERROR %lX\n", us->pusb_dev->status);
                us->transport_reset(us);
                return USB_STOR_TRANSPORT_ERROR;
        }
@@ -853,7 +862,7 @@ do_retry:
                status = usb_stor_CBI_get_status(psrb, us);
 
        if ((result < 0) && !(us->pusb_dev->status & USB_ST_STALLED)) {
-               USB_STOR_PRINTF(" AUTO REQUEST ERROR %d\n",
+               USB_STOR_PRINTF(" AUTO REQUEST ERROR %ld\n",
                                us->pusb_dev->status);
                return USB_STOR_TRANSPORT_ERROR;
        }
@@ -883,7 +892,7 @@ do_retry:
                                srb->sense_buf[12], srb->sense_buf[13]);
                        return USB_STOR_TRANSPORT_FAILED;
                } else {
-                       wait_ms(100);
+                       mdelay(100);
                        goto do_retry;
                }
                break;
@@ -956,10 +965,12 @@ static int usb_test_unit_ready(ccb *srb, struct us_data *ss)
                srb->cmd[1] = srb->lun << 5;
                srb->datalen = 0;
                srb->cmdlen = 12;
-               if (ss->transport(srb, ss) == USB_STOR_TRANSPORT_GOOD)
+               if (ss->transport(srb, ss) == USB_STOR_TRANSPORT_GOOD) {
+                       ss->flags |= USB_READY;
                        return 0;
+               }
                usb_request_sense(srb, ss);
-               wait_ms(100);
+               mdelay(100);
        } while (retries--);
 
        return -1;
@@ -1041,14 +1052,13 @@ static void usb_bin_fixup(struct usb_device_descriptor descriptor,
 }
 #endif /* CONFIG_USB_BIN_FIXUP */
 
-#define USB_MAX_READ_BLK 20
-
 unsigned long usb_stor_read(int device, unsigned long blknr,
                            unsigned long blkcnt, void *buffer)
 {
        unsigned long start, blks, buf_addr;
        unsigned short smallblks;
        struct usb_device *dev;
+       struct us_data *ss;
        int retry, i;
        ccb *srb = &usb_ccb;
 
@@ -1066,18 +1076,13 @@ unsigned long usb_stor_read(int device, unsigned long blknr,
                if (dev->devnum == usb_dev_desc[device].target)
                        break;
        }
+       ss = (struct us_data *)dev->privptr;
 
        usb_disable_asynch(1); /* asynch transfer not allowed */
        srb->lun = usb_dev_desc[device].lun;
        buf_addr = (unsigned long)buffer;
        start = blknr;
        blks = blkcnt;
-       if (usb_test_unit_ready(srb, (struct us_data *)dev->privptr)) {
-               printf("Device NOT ready\n   Request Sense returned %02X %02X"
-                      " %02X\n", srb->sense_buf[2], srb->sense_buf[12],
-                      srb->sense_buf[13]);
-               return 0;
-       }
 
        USB_STOR_PRINTF("\nusb_read: dev %d startblk %lx, blccnt %lx"
                        " buffer %lx\n", device, start, blks, buf_addr);
@@ -1086,19 +1091,18 @@ unsigned long usb_stor_read(int device, unsigned long blknr,
                /* XXX need some comment here */
                retry = 2;
                srb->pdata = (unsigned char *)buf_addr;
-               if (blks > USB_MAX_READ_BLK)
-                       smallblks = USB_MAX_READ_BLK;
+               if (blks > USB_MAX_XFER_BLK)
+                       smallblks = USB_MAX_XFER_BLK;
                else
                        smallblks = (unsigned short) blks;
 retry_it:
-               if (smallblks == USB_MAX_READ_BLK)
+               if (smallblks == USB_MAX_XFER_BLK)
                        usb_show_progress();
                srb->datalen = usb_dev_desc[device].blksz * smallblks;
                srb->pdata = (unsigned char *)buf_addr;
-               if (usb_read_10(srb, (struct us_data *)dev->privptr, start,
-                   smallblks)) {
+               if (usb_read_10(srb, ss, start, smallblks)) {
                        USB_STOR_PRINTF("Read ERROR\n");
-                       usb_request_sense(srb, (struct us_data *)dev->privptr);
+                       usb_request_sense(srb, ss);
                        if (retry--)
                                goto retry_it;
                        blkcnt -= blks;
@@ -1108,24 +1112,24 @@ retry_it:
                blks -= smallblks;
                buf_addr += srb->datalen;
        } while (blks != 0);
+       ss->flags &= ~USB_READY;
 
        USB_STOR_PRINTF("usb_read: end startblk %lx, blccnt %x buffer %lx\n",
                        start, smallblks, buf_addr);
 
        usb_disable_asynch(0); /* asynch transfer allowed */
-       if (blkcnt >= USB_MAX_READ_BLK)
+       if (blkcnt >= USB_MAX_XFER_BLK)
                debug("\n");
        return blkcnt;
 }
 
-#define USB_MAX_WRITE_BLK 20
-
 unsigned long usb_stor_write(int device, unsigned long blknr,
                                unsigned long blkcnt, const void *buffer)
 {
        unsigned long start, blks, buf_addr;
        unsigned short smallblks;
        struct usb_device *dev;
+       struct us_data *ss;
        int retry, i;
        ccb *srb = &usb_ccb;
 
@@ -1143,6 +1147,7 @@ unsigned long usb_stor_write(int device, unsigned long blknr,
                if (dev->devnum == usb_dev_desc[device].target)
                        break;
        }
+       ss = (struct us_data *)dev->privptr;
 
        usb_disable_asynch(1); /* asynch transfer not allowed */
 
@@ -1150,12 +1155,6 @@ unsigned long usb_stor_write(int device, unsigned long blknr,
        buf_addr = (unsigned long)buffer;
        start = blknr;
        blks = blkcnt;
-       if (usb_test_unit_ready(srb, (struct us_data *)dev->privptr)) {
-               printf("Device NOT ready\n   Request Sense returned %02X %02X"
-                      " %02X\n", srb->sense_buf[2], srb->sense_buf[12],
-                       srb->sense_buf[13]);
-               return 0;
-       }
 
        USB_STOR_PRINTF("\nusb_write: dev %d startblk %lx, blccnt %lx"
                        " buffer %lx\n", device, start, blks, buf_addr);
@@ -1166,19 +1165,18 @@ unsigned long usb_stor_write(int device, unsigned long blknr,
                 */
                retry = 2;
                srb->pdata = (unsigned char *)buf_addr;
-               if (blks > USB_MAX_WRITE_BLK)
-                       smallblks = USB_MAX_WRITE_BLK;
+               if (blks > USB_MAX_XFER_BLK)
+                       smallblks = USB_MAX_XFER_BLK;
                else
                        smallblks = (unsigned short) blks;
 retry_it:
-               if (smallblks == USB_MAX_WRITE_BLK)
+               if (smallblks == USB_MAX_XFER_BLK)
                        usb_show_progress();
                srb->datalen = usb_dev_desc[device].blksz * smallblks;
                srb->pdata = (unsigned char *)buf_addr;
-               if (usb_write_10(srb, (struct us_data *)dev->privptr, start,
-                   smallblks)) {
+               if (usb_write_10(srb, ss, start, smallblks)) {
                        USB_STOR_PRINTF("Write ERROR\n");
-                       usb_request_sense(srb, (struct us_data *)dev->privptr);
+                       usb_request_sense(srb, ss);
                        if (retry--)
                                goto retry_it;
                        blkcnt -= blks;
@@ -1188,12 +1186,13 @@ retry_it:
                blks -= smallblks;
                buf_addr += srb->datalen;
        } while (blks != 0);
+       ss->flags &= ~USB_READY;
 
        USB_STOR_PRINTF("usb_write: end startblk %lx, blccnt %x buffer %lx\n",
                        start, smallblks, buf_addr);
 
        usb_disable_asynch(0); /* asynch transfer allowed */
-       if (blkcnt >= USB_MAX_WRITE_BLK)
+       if (blkcnt >= USB_MAX_XFER_BLK)
                debug("\n");
        return blkcnt;
 
@@ -1344,7 +1343,8 @@ int usb_stor_get_info(struct usb_device *dev, struct us_data *ss,
                      block_dev_desc_t *dev_desc)
 {
        unsigned char perq, modi;
-       unsigned long cap[2];
+       ALLOC_CACHE_ALIGN_BUFFER(unsigned long, cap, 2);
+       ALLOC_CACHE_ALIGN_BUFFER(unsigned char, usb_stor_buf, 36);
        unsigned long *capacity, *blksz;
        ccb *pccb = &usb_ccb;
 
@@ -1368,9 +1368,9 @@ int usb_stor_get_info(struct usb_device *dev, struct us_data *ss,
                /* drive is removable */
                dev_desc->removable = 1;
        }
-       memcpy(&dev_desc->vendor[0], &usb_stor_buf[8], 8);
-       memcpy(&dev_desc->product[0], &usb_stor_buf[16], 16);
-       memcpy(&dev_desc->revision[0], &usb_stor_buf[32], 4);
+       memcpy(&dev_desc->vendor[0], (const void *) &usb_stor_buf[8], 8);
+       memcpy(&dev_desc->product[0], (const void *) &usb_stor_buf[16], 16);
+       memcpy(&dev_desc->revision[0], (const void *) &usb_stor_buf[32], 4);
        dev_desc->vendor[8] = 0;
        dev_desc->product[16] = 0;
        dev_desc->revision[4] = 0;
@@ -1398,6 +1398,7 @@ int usb_stor_get_info(struct usb_device *dev, struct us_data *ss,
                cap[0] = 2880;
                cap[1] = 0x200;
        }
+       ss->flags &= ~USB_READY;
        USB_STOR_PRINTF("Read Capacity returns: 0x%lx, 0x%lx\n", cap[0],
                        cap[1]);
 #if 0