]> git.kernelconcepts.de Git - karo-tx-uboot.git/blobdiff - net/eth.c
net: Clean up network stack names used in DM drivers
[karo-tx-uboot.git] / net / eth.c
index a5780c5462e6fc7ddf8f14a99cab50f873ad7b56..1abf0274b489d98b79ef94885682fab0f18095e6 100644 (file)
--- a/net/eth.c
+++ b/net/eth.c
@@ -1,31 +1,21 @@
 /*
- * (C) Copyright 2001-2010
+ * (C) Copyright 2001-2015
  * Wolfgang Denk, DENX Software Engineering, wd@denx.de.
+ * Joe Hershberger, National Instruments
  *
- * See file CREDITS for list of people who contributed to this
- * project.
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License as
- * published by the Free Software Foundation; either version 2 of
- * the License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
- * MA 02111-1307 USA
+ * SPDX-License-Identifier:    GPL-2.0+
  */
 
 #include <common.h>
 #include <command.h>
+#include <dm.h>
 #include <net.h>
 #include <miiphy.h>
 #include <phy.h>
+#include <asm/errno.h>
+#include <dm/device-internal.h>
+
+DECLARE_GLOBAL_DATA_PTR;
 
 void eth_parse_enetaddr(const char *addr, uchar *enetaddr)
 {
@@ -62,6 +52,23 @@ int eth_getenv_enetaddr_by_index(const char *base_name, int index,
        return eth_getenv_enetaddr(enetvar, enetaddr);
 }
 
+static inline int eth_setenv_enetaddr_by_index(const char *base_name, int index,
+                                uchar *enetaddr)
+{
+       char enetvar[32];
+       sprintf(enetvar, index ? "%s%daddr" : "%saddr", base_name, index);
+       return eth_setenv_enetaddr(enetvar, enetaddr);
+}
+
+static void eth_env_init(void)
+{
+       const char *s;
+
+       s = getenv("bootfile");
+       if (s != NULL)
+               copy_filename(BootFile, s, sizeof(BootFile));
+}
+
 static int eth_mac_skip(int index)
 {
        char enetvar[15];
@@ -70,6 +77,341 @@ static int eth_mac_skip(int index)
        return ((skip_state = getenv(enetvar)) != NULL);
 }
 
+static void eth_current_changed(void);
+
+#ifdef CONFIG_DM_ETH
+/**
+ * struct eth_device_priv - private structure for each Ethernet device
+ *
+ * @state: The state of the Ethernet MAC driver (defined by enum eth_state_t)
+ */
+struct eth_device_priv {
+       enum eth_state_t state;
+};
+
+/**
+ * struct eth_uclass_priv - The structure attached to the uclass itself
+ *
+ * @current: The Ethernet device that the network functions are using
+ */
+struct eth_uclass_priv {
+       struct udevice *current;
+};
+
+static struct eth_uclass_priv *eth_get_uclass_priv(void)
+{
+       struct uclass *uc;
+
+       uclass_get(UCLASS_ETH, &uc);
+       assert(uc);
+       return uc->priv;
+}
+
+static void eth_set_current_to_next(void)
+{
+       struct eth_uclass_priv *uc_priv;
+
+       uc_priv = eth_get_uclass_priv();
+       if (uc_priv->current)
+               uclass_next_device(&uc_priv->current);
+       if (!uc_priv->current)
+               uclass_first_device(UCLASS_ETH, &uc_priv->current);
+}
+
+struct udevice *eth_get_dev(void)
+{
+       struct eth_uclass_priv *uc_priv;
+
+       uc_priv = eth_get_uclass_priv();
+       if (!uc_priv->current)
+               uclass_first_device(UCLASS_ETH,
+                                   &uc_priv->current);
+       return uc_priv->current;
+}
+
+static void eth_set_dev(struct udevice *dev)
+{
+       device_probe(dev);
+       eth_get_uclass_priv()->current = dev;
+}
+
+unsigned char *eth_get_ethaddr(void)
+{
+       struct eth_pdata *pdata;
+
+       if (eth_get_dev()) {
+               pdata = eth_get_dev()->platdata;
+               return pdata->enetaddr;
+       }
+
+       return NULL;
+}
+
+/* Set active state without calling start on the driver */
+int eth_init_state_only(void)
+{
+       struct udevice *current;
+       struct eth_device_priv *priv;
+
+       current = eth_get_dev();
+       if (!current || !device_active(current))
+               return -EINVAL;
+
+       priv = current->uclass_priv;
+       priv->state = ETH_STATE_ACTIVE;
+
+       return 0;
+}
+
+/* Set passive state without calling stop on the driver */
+void eth_halt_state_only(void)
+{
+       struct udevice *current;
+       struct eth_device_priv *priv;
+
+       current = eth_get_dev();
+       if (!current || !device_active(current))
+               return;
+
+       priv = current->uclass_priv;
+       priv->state = ETH_STATE_PASSIVE;
+}
+
+int eth_get_dev_index(void)
+{
+       if (eth_get_dev())
+               return eth_get_dev()->seq;
+       return -1;
+}
+
+int eth_init(void)
+{
+       struct udevice *current;
+       struct udevice *old_current;
+
+       current = eth_get_dev();
+       if (!current) {
+               printf("No ethernet found.\n");
+               return -ENODEV;
+       }
+
+       old_current = current;
+       do {
+               debug("Trying %s\n", current->name);
+
+               if (device_active(current)) {
+                       uchar env_enetaddr[6];
+                       struct eth_pdata *pdata = current->platdata;
+
+                       /* Sync environment with network device */
+                       if (eth_getenv_enetaddr_by_index("eth", current->seq,
+                                                        env_enetaddr))
+                               memcpy(pdata->enetaddr, env_enetaddr, 6);
+                       else
+                               memset(pdata->enetaddr, 0, 6);
+
+                       if (eth_get_ops(current)->start(current) >= 0) {
+                               struct eth_device_priv *priv =
+                                       current->uclass_priv;
+
+                               priv->state = ETH_STATE_ACTIVE;
+                               return 0;
+                       }
+               }
+               debug("FAIL\n");
+
+               /* This will ensure the new "current" attempted to probe */
+               eth_try_another(0);
+               current = eth_get_dev();
+       } while (old_current != current);
+
+       return -ENODEV;
+}
+
+void eth_halt(void)
+{
+       struct udevice *current;
+       struct eth_device_priv *priv;
+
+       current = eth_get_dev();
+       if (!current || !device_active(current))
+               return;
+
+       eth_get_ops(current)->stop(current);
+       priv = current->uclass_priv;
+       priv->state = ETH_STATE_PASSIVE;
+}
+
+int eth_send(void *packet, int length)
+{
+       struct udevice *current;
+
+       current = eth_get_dev();
+       if (!current)
+               return -ENODEV;
+
+       if (!device_active(current))
+               return -EINVAL;
+
+       return eth_get_ops(current)->send(current, packet, length);
+}
+
+int eth_rx(void)
+{
+       struct udevice *current;
+
+       current = eth_get_dev();
+       if (!current)
+               return -ENODEV;
+
+       if (!device_active(current))
+               return -EINVAL;
+
+       return eth_get_ops(current)->recv(current);
+}
+
+static int eth_write_hwaddr(struct udevice *dev)
+{
+       struct eth_pdata *pdata = dev->platdata;
+       int ret = 0;
+
+       if (!dev || !device_active(dev))
+               return -EINVAL;
+
+       /* seq is valid since the device is active */
+       if (eth_get_ops(dev)->write_hwaddr && !eth_mac_skip(dev->seq)) {
+               if (!is_valid_ether_addr(pdata->enetaddr)) {
+                       printf("\nError: %s address %pM illegal value\n",
+                              dev->name, pdata->enetaddr);
+                       return -EINVAL;
+               }
+
+               ret = eth_get_ops(dev)->write_hwaddr(dev);
+               if (ret)
+                       printf("\nWarning: %s failed to set MAC address\n",
+                              dev->name);
+       }
+
+       return ret;
+}
+
+int eth_initialize(void)
+{
+       int num_devices = 0;
+       struct udevice *dev;
+
+       bootstage_mark(BOOTSTAGE_ID_NET_ETH_START);
+       eth_env_init();
+
+       /*
+        * Devices need to write the hwaddr even if not started so that Linux
+        * will have access to the hwaddr that u-boot stored for the device.
+        * This is accomplished by attempting to probe each device and calling
+        * their write_hwaddr() operation.
+        */
+       uclass_first_device(UCLASS_ETH, &dev);
+       if (!dev) {
+               printf("No ethernet found.\n");
+               bootstage_error(BOOTSTAGE_ID_NET_ETH_START);
+       } else {
+               bootstage_mark(BOOTSTAGE_ID_NET_ETH_INIT);
+               do {
+                       if (num_devices)
+                               printf(", ");
+
+                       printf("eth%d: %s", dev->seq, dev->name);
+
+                       eth_write_hwaddr(dev);
+
+                       uclass_next_device(&dev);
+                       num_devices++;
+               } while (dev);
+
+               putc('\n');
+       }
+
+       return num_devices;
+}
+
+static int eth_post_bind(struct udevice *dev)
+{
+       if (strchr(dev->name, ' ')) {
+               printf("\nError: eth device name \"%s\" has a space!\n",
+                      dev->name);
+               return -EINVAL;
+       }
+
+       return 0;
+}
+
+static int eth_pre_unbind(struct udevice *dev)
+{
+       /* Don't hang onto a pointer that is going away */
+       if (dev == eth_get_uclass_priv()->current)
+               eth_set_dev(NULL);
+
+       return 0;
+}
+
+static int eth_post_probe(struct udevice *dev)
+{
+       struct eth_device_priv *priv = dev->uclass_priv;
+       struct eth_pdata *pdata = dev->platdata;
+       unsigned char env_enetaddr[6];
+
+       priv->state = ETH_STATE_INIT;
+
+       /* Check if the device has a MAC address in ROM */
+       if (eth_get_ops(dev)->read_rom_hwaddr)
+               eth_get_ops(dev)->read_rom_hwaddr(dev);
+
+       eth_getenv_enetaddr_by_index("eth", dev->seq, env_enetaddr);
+       if (!is_zero_ether_addr(env_enetaddr)) {
+               if (!is_zero_ether_addr(pdata->enetaddr) &&
+                   memcmp(pdata->enetaddr, env_enetaddr, 6)) {
+                       printf("\nWarning: %s MAC addresses don't match:\n",
+                              dev->name);
+                       printf("Address in SROM is         %pM\n",
+                              pdata->enetaddr);
+                       printf("Address in environment is  %pM\n",
+                              env_enetaddr);
+               }
+
+               /* Override the ROM MAC address */
+               memcpy(pdata->enetaddr, env_enetaddr, 6);
+       } else if (is_valid_ether_addr(pdata->enetaddr)) {
+               eth_setenv_enetaddr_by_index("eth", dev->seq, pdata->enetaddr);
+               printf("\nWarning: %s using MAC address from ROM\n",
+                      dev->name);
+       } else if (is_zero_ether_addr(pdata->enetaddr)) {
+               printf("\nError: %s address not set.\n",
+                      dev->name);
+               return -EINVAL;
+       }
+
+       return 0;
+}
+
+static int eth_pre_remove(struct udevice *dev)
+{
+       eth_get_ops(dev)->stop(dev);
+
+       return 0;
+}
+
+UCLASS_DRIVER(eth) = {
+       .name           = "eth",
+       .id             = UCLASS_ETH,
+       .post_bind      = eth_post_bind,
+       .pre_unbind     = eth_pre_unbind,
+       .post_probe     = eth_post_probe,
+       .pre_remove     = eth_pre_remove,
+       .priv_auto_alloc_size = sizeof(struct eth_uclass_priv),
+       .per_device_auto_alloc_size = sizeof(struct eth_device_priv),
+};
+#endif
+
+#ifndef CONFIG_DM_ETH
 /*
  * CPU and board-specific Ethernet initializations.  Aliased function
  * signals caller to move on
@@ -81,24 +423,21 @@ static int __def_eth_init(bd_t *bis)
 int cpu_eth_init(bd_t *bis) __attribute__((weak, alias("__def_eth_init")));
 int board_eth_init(bd_t *bis) __attribute__((weak, alias("__def_eth_init")));
 
-extern int mv6446x_eth_initialize(bd_t *);
-
 #ifdef CONFIG_API
-extern void (*push_packet)(volatile void *, int);
-
 static struct {
        uchar data[PKTSIZE];
        int length;
 } eth_rcv_bufs[PKTBUFSRX];
 
-static unsigned int eth_rcv_current = 0, eth_rcv_last = 0;
+static unsigned int eth_rcv_current, eth_rcv_last;
 #endif
 
-static struct eth_device *eth_devices, *eth_current;
+static struct eth_device *eth_devices;
+struct eth_device *eth_current;
 
-struct eth_device *eth_get_dev(void)
+static void eth_set_current_to_next(void)
 {
-       return eth_current;
+       eth_current = eth_current->next;
 }
 
 struct eth_device *eth_get_dev_by_name(const char *devname)
@@ -143,43 +482,25 @@ struct eth_device *eth_get_dev_by_index(int index)
        return target_dev;
 }
 
-int eth_get_dev_index (void)
+int eth_get_dev_index(void)
 {
-       if (!eth_current) {
+       if (!eth_current)
                return -1;
-       }
 
        return eth_current->index;
 }
 
-static void eth_current_changed(void)
-{
-       char *act = getenv("ethact");
-       /* update current ethernet name */
-       if (eth_current) {
-               if (act == NULL || strcmp(act, eth_current->name) != 0)
-                       setenv("ethact", eth_current->name);
-       }
-       /*
-        * remove the variable completely if there is no active
-        * interface
-        */
-       else if (act != NULL)
-               setenv("ethact", NULL);
-}
-
 int eth_write_hwaddr(struct eth_device *dev, const char *base_name,
                   int eth_number)
 {
        unsigned char env_enetaddr[6];
        int ret = 0;
 
-       if (!eth_getenv_enetaddr_by_index(base_name, eth_number, env_enetaddr))
-               return -1;
+       eth_getenv_enetaddr_by_index(base_name, eth_number, env_enetaddr);
 
-       if (memcmp(env_enetaddr, "\0\0\0\0\0\0", 6)) {
-               if (memcmp(dev->enetaddr, "\0\0\0\0\0\0", 6) &&
-                       memcmp(dev->enetaddr, env_enetaddr, 6)) {
+       if (!is_zero_ether_addr(env_enetaddr)) {
+               if (!is_zero_ether_addr(dev->enetaddr) &&
+                   memcmp(dev->enetaddr, env_enetaddr, 6)) {
                        printf("\nWarning: %s MAC addresses don't match:\n",
                                dev->name);
                        printf("Address in SROM is         %pM\n",
@@ -189,12 +510,27 @@ int eth_write_hwaddr(struct eth_device *dev, const char *base_name,
                }
 
                memcpy(dev->enetaddr, env_enetaddr, 6);
+       } else if (is_valid_ether_addr(dev->enetaddr)) {
+               eth_setenv_enetaddr_by_index(base_name, eth_number,
+                                            dev->enetaddr);
+               printf("\nWarning: %s using MAC address from net device\n",
+                       dev->name);
+       } else if (is_zero_ether_addr(dev->enetaddr)) {
+               printf("\nError: %s address not set.\n",
+                      dev->name);
+               return -EINVAL;
        }
 
-       if (dev->write_hwaddr &&
-               !eth_mac_skip(eth_number) &&
-               is_valid_ether_addr(dev->enetaddr)) {
+       if (dev->write_hwaddr && !eth_mac_skip(eth_number)) {
+               if (!is_valid_ether_addr(dev->enetaddr)) {
+                       printf("\nError: %s address %pM illegal value\n",
+                                dev->name, dev->enetaddr);
+                       return -EINVAL;
+               }
+
                ret = dev->write_hwaddr(dev);
+               if (ret)
+                       printf("\nWarning: %s failed to set MAC address\n", dev->name);
        }
 
        return ret;
@@ -203,15 +539,15 @@ int eth_write_hwaddr(struct eth_device *dev, const char *base_name,
 int eth_register(struct eth_device *dev)
 {
        struct eth_device *d;
-       static int index = 0;
+       static int index;
 
-       assert(strlen(dev->name) < NAMESIZE);
+       assert(strlen(dev->name) < sizeof(dev->name));
 
        if (!eth_devices) {
                eth_current = eth_devices = dev;
                eth_current_changed();
        } else {
-               for (d=eth_devices; d->next!=eth_devices; d=d->next)
+               for (d = eth_devices; d->next != eth_devices; d = d->next)
                        ;
                d->next = dev;
        }
@@ -229,7 +565,7 @@ int eth_unregister(struct eth_device *dev)
 
        /* No device */
        if (!eth_devices)
-               return -1;
+               return -ENODEV;
 
        for (cur = eth_devices; cur->next != eth_devices && cur->next != dev;
             cur = cur->next)
@@ -237,7 +573,7 @@ int eth_unregister(struct eth_device *dev)
 
        /* Device not found */
        if (cur->next != dev)
-               return -1;
+               return -ENODEV;
 
        cur->next = dev->next;
 
@@ -252,14 +588,14 @@ int eth_unregister(struct eth_device *dev)
        return 0;
 }
 
-int eth_initialize(bd_t *bis)
+int eth_initialize(void)
 {
        int num_devices = 0;
        eth_devices = NULL;
        eth_current = NULL;
 
-       show_boot_progress (64);
-#if defined(CONFIG_MII) || defined(CONFIG_CMD_MII)
+       bootstage_mark(BOOTSTAGE_ID_NET_ETH_START);
+#if defined(CONFIG_MII) || defined(CONFIG_CMD_MII) || defined(CONFIG_PHYLIB)
        miiphy_init();
 #endif
 
@@ -267,53 +603,52 @@ int eth_initialize(bd_t *bis)
        phy_init();
 #endif
 
+       eth_env_init();
+
        /*
         * If board-specific initialization exists, call it.
         * If not, call a CPU-specific one
         */
        if (board_eth_init != __def_eth_init) {
-               if (board_eth_init(bis) < 0)
+               if (board_eth_init(gd->bd) < 0)
                        printf("Board Net Initialization Failed\n");
        } else if (cpu_eth_init != __def_eth_init) {
-               if (cpu_eth_init(bis) < 0)
+               if (cpu_eth_init(gd->bd) < 0)
                        printf("CPU Net Initialization Failed\n");
        } else
                printf("Net Initialization Skipped\n");
 
-#if defined(CONFIG_DB64460) || defined(CONFIG_P3Mx)
-       mv6446x_eth_initialize(bis);
-#endif
        if (!eth_devices) {
-               puts ("No ethernet found.\n");
-               show_boot_progress (-64);
+               puts("No ethernet found.\n");
+               bootstage_error(BOOTSTAGE_ID_NET_ETH_START);
        } else {
                struct eth_device *dev = eth_devices;
-               char *ethprime = getenv ("ethprime");
+               char *ethprime = getenv("ethprime");
 
-               show_boot_progress (65);
+               bootstage_mark(BOOTSTAGE_ID_NET_ETH_INIT);
                do {
                        if (dev->index)
-                               puts (", ");
+                               puts(", ");
 
                        printf("%s", dev->name);
 
-                       if (ethprime && strcmp (dev->name, ethprime) == 0) {
+                       if (ethprime && strcmp(dev->name, ethprime) == 0) {
                                eth_current = dev;
-                               puts (" [PRIME]");
+                               puts(" [PRIME]");
                        }
 
                        if (strchr(dev->name, ' '))
-                               puts("\nWarning: eth device name has a space!\n");
+                               puts("\nWarning: eth device name has a space!"
+                                       "\n");
 
-                       if (eth_write_hwaddr(dev, "eth", dev->index))
-                               puts("\nWarning: failed to set MAC address\n");
+                       eth_write_hwaddr(dev, "eth", dev->index);
 
                        dev = dev->next;
                        num_devices++;
-               } while(dev != eth_devices);
+               } while (dev != eth_devices);
 
                eth_current_changed();
-               putc ('\n');
+               putc('\n');
        }
 
        return num_devices;
@@ -324,9 +659,9 @@ int eth_initialize(bd_t *bis)
  * mcast_addr: multicast ipaddr from which multicast Mac is made
  * join: 1=join, 0=leave.
  */
-int eth_mcast_join( IPaddr_t mcast_ip, u8 join)
+int eth_mcast_join(IPaddr_t mcast_ip, int join)
 {
- u8 mcast_mac[6];
      u8 mcast_mac[6];
        if (!eth_current || !eth_current->mcast)
                return -1;
        mcast_mac[5] = htonl(mcast_ip) & 0xff;
@@ -343,7 +678,7 @@ int eth_mcast_join( IPaddr_t mcast_ip, u8 join)
  * some other adapter -- hash tables
  */
 #define CRCPOLY_LE 0xedb88320
-u32 ether_crc (size_t len, unsigned char const *p)
+u32 ether_crc(size_t len, unsigned char const *p)
 {
        int i;
        u32 crc;
@@ -365,13 +700,13 @@ u32 ether_crc (size_t len, unsigned char const *p)
 #endif
 
 
-int eth_init(bd_t *bis)
+int eth_init(void)
 {
        struct eth_device *old_current, *dev;
 
        if (!eth_current) {
-               puts ("No ethernet found.\n");
-               return -1;
+               puts("No ethernet found.\n");
+               return -ENODEV;
        }
 
        /* Sync environment with network devices */
@@ -390,7 +725,7 @@ int eth_init(bd_t *bis)
        do {
                debug("Trying %s\n", eth_current->name);
 
-               if (eth_current->init(eth_current,bis) >= 0) {
+               if (eth_current->init(eth_current, gd->bd) >= 0) {
                        eth_current->state = ETH_STATE_ACTIVE;
 
                        return 0;
@@ -400,7 +735,7 @@ int eth_init(bd_t *bis)
                eth_try_another(0);
        } while (old_current != eth_current);
 
-       return -1;
+       return -ETIMEDOUT;
 }
 
 void eth_halt(void)
@@ -413,10 +748,10 @@ void eth_halt(void)
        eth_current->state = ETH_STATE_PASSIVE;
 }
 
-int eth_send(volatile void *packet, int length)
+int eth_send(void *packet, int length)
 {
        if (!eth_current)
-               return -1;
+               return -ENODEV;
 
        return eth_current->send(eth_current, packet, length);
 }
@@ -424,15 +759,16 @@ int eth_send(volatile void *packet, int length)
 int eth_rx(void)
 {
        if (!eth_current)
-               return -1;
+               return -ENODEV;
 
        return eth_current->recv(eth_current);
 }
+#endif /* ifndef CONFIG_DM_ETH */
 
 #ifdef CONFIG_API
-static void eth_save_packet(volatile void *packet, int length)
+static void eth_save_packet(void *packet, int length)
 {
-       volatile char *p = packet;
+       char *p = packet;
        int i;
 
        if ((eth_rcv_last+1) % PKTBUFSRX == eth_rcv_current)
@@ -448,9 +784,9 @@ static void eth_save_packet(volatile void *packet, int length)
        eth_rcv_last = (eth_rcv_last + 1) % PKTBUFSRX;
 }
 
-int eth_receive(volatile void *packet, int length)
+int eth_receive(void *packet, int length)
 {
-       volatile char *p = packet;
+       char *p = packet;
        void *pp = push_packet;
        int i;
 
@@ -463,10 +799,7 @@ int eth_receive(volatile void *packet, int length)
                        return -1;
        }
 
-       if (length < eth_rcv_bufs[eth_rcv_current].length)
-               return -1;
-
-       length = eth_rcv_bufs[eth_rcv_current].length;
+       length = min(eth_rcv_bufs[eth_rcv_current].length, length);
 
        for (i = 0; i < length; i++)
                p[i] = eth_rcv_bufs[eth_rcv_current].data[i];
@@ -476,63 +809,74 @@ int eth_receive(volatile void *packet, int length)
 }
 #endif /* CONFIG_API */
 
+static void eth_current_changed(void)
+{
+       char *act = getenv("ethact");
+       /* update current ethernet name */
+       if (eth_get_dev()) {
+               if (act == NULL || strcmp(act, eth_get_name()) != 0)
+                       setenv("ethact", eth_get_name());
+       }
+       /*
+        * remove the variable completely if there is no active
+        * interface
+        */
+       else if (act != NULL)
+               setenv("ethact", NULL);
+}
+
 void eth_try_another(int first_restart)
 {
-       static struct eth_device *first_failed = NULL;
+       static void *first_failed;
        char *ethrotate;
 
        /*
         * Do not rotate between network interfaces when
         * 'ethrotate' variable is set to 'no'.
         */
-       if (((ethrotate = getenv ("ethrotate")) != NULL) &&
-           (strcmp(ethrotate, "no") == 0))
+       ethrotate = getenv("ethrotate");
+       if ((ethrotate != NULL) && (strcmp(ethrotate, "no") == 0))
                return;
 
-       if (!eth_current)
+       if (!eth_get_dev())
                return;
 
-       if (first_restart) {
-               first_failed = eth_current;
-       }
+       if (first_restart)
+               first_failed = eth_get_dev();
 
-       eth_current = eth_current->next;
+       eth_set_current_to_next();
 
        eth_current_changed();
 
-       if (first_failed == eth_current) {
+       if (first_failed == eth_get_dev())
                NetRestartWrap = 1;
-       }
 }
 
 void eth_set_current(void)
 {
-       static char *act = NULL;
-       static int  env_changed_id = 0;
-       struct eth_device* old_current;
+       static char *act;
+       static int  env_changed_id;
+       void *old_current;
        int     env_id;
 
-       if (!eth_current)       /* XXX no current */
-               return;
-
        env_id = get_env_id();
        if ((act == NULL) || (env_changed_id != env_id)) {
                act = getenv("ethact");
                env_changed_id = env_id;
        }
        if (act != NULL) {
-               old_current = eth_current;
+               old_current = eth_get_dev();
                do {
-                       if (strcmp(eth_current->name, act) == 0)
+                       if (strcmp(eth_get_name(), act) == 0)
                                return;
-                       eth_current = eth_current->next;
-               } while (old_current != eth_current);
+                       eth_set_current_to_next();
+               } while (old_current != eth_get_dev());
        }
 
        eth_current_changed();
 }
 
-char *eth_get_name (void)
+const char *eth_get_name(void)
 {
-       return (eth_current ? eth_current->name : "unknown");
+       return eth_get_dev() ? eth_get_dev()->name : "unknown";
 }