]> git.kernelconcepts.de Git - karo-tx-uboot.git/blobdiff - net/tftp.c
Merge branch 'master' of git://git.denx.de/u-boot-microblaze
[karo-tx-uboot.git] / net / tftp.c
index 4c052661c7ad500d1a9035b7e6db50ef9ddf369b..59a8ebb3cf339b3c40ff24846c13406e5dc0b9a4 100644 (file)
@@ -2,6 +2,8 @@
  * Copyright 1994, 1995, 2000 Neil Russell.
  * (See License)
  * Copyright 2000, 2001 DENX Software Engineering, Wolfgang Denk, wd@denx.de
+ * Copyright 2011 Comelit Group SpA,
+ *                Luca Ceresoli <luca.ceresoli@comelit.it>
  */
 
 #include <common.h>
@@ -9,6 +11,9 @@
 #include <net.h>
 #include "tftp.h"
 #include "bootp.h"
+#ifdef CONFIG_SYS_DIRECT_FLASH_TFTP
+#include <flash.h>
+#endif
 
 /* Well known TFTP port # */
 #define WELL_KNOWN_PORT        69
@@ -58,9 +63,9 @@ enum {
        TFTP_ERR_FILE_ALREADY_EXISTS = 6,
 };
 
-static IPaddr_t TftpServerIP;
+static IPaddr_t TftpRemoteIP;
 /* The UDP port at their end */
-static int     TftpServerPort;
+static int     TftpRemotePort;
 /* The UDP port at our end */
 static int     TftpOurPort;
 static int     TftpTimeoutCount;
@@ -79,12 +84,20 @@ static int  TftpTsize;
 /* The number of hashes we printed */
 static short   TftpNumchars;
 #endif
+#ifdef CONFIG_CMD_TFTPPUT
+static int     TftpWriting;    /* 1 if writing, else 0 */
+static int     TftpFinalBlock; /* 1 if we have sent the last block */
+#else
+#define TftpWriting    0
+#endif
 
-#define STATE_RRQ      1
+#define STATE_SEND_RRQ 1
 #define STATE_DATA     2
 #define STATE_TOO_LARGE        3
 #define STATE_BAD_MAGIC        4
 #define STATE_OACK     5
+#define STATE_RECV_WRQ 6
+#define STATE_SEND_WRQ 7
 
 /* default TFTP block size */
 #define TFTP_BLOCK_SIZE                512
@@ -102,10 +115,6 @@ static char default_filename[DEFAULT_NAME_LEN];
 
 static char tftp_filename[MAX_LEN];
 
-#ifdef CONFIG_SYS_DIRECT_FLASH_TFTP
-extern flash_info_t flash_info[];
-#endif
-
 /* 512 is poor choice for ethernet, MTU is typically 1500.
  * Minus eth.hdrs thats 1468.  Can get 2x better throughput with
  * almost-MTU block sizes.  At least try... fall back to 512 if need be.
@@ -125,9 +134,8 @@ static unsigned short TftpBlkSizeOption = TFTP_MTU_BLOCKSIZE;
 #define MTFTP_BITMAPSIZE       0x1000
 static unsigned *Bitmap;
 static int PrevBitmapHole, Mapsize = MTFTP_BITMAPSIZE;
-static uchar ProhibitMcast = 0, MasterClient = 0;
-static uchar Multicast = 0;
-extern IPaddr_t Mcast_addr;
+static uchar ProhibitMcast, MasterClient;
+static uchar Multicast;
 static int Mcast_port;
 static ulong TftpEndingBlock; /* can get 'last' block before done..*/
 
@@ -136,8 +144,10 @@ static void parse_multicast_oack(char *pkt, int len);
 static void
 mcast_cleanup(void)
 {
-       if (Mcast_addr) eth_mcast_join(Mcast_addr, 0);
-       if (Bitmap) free(Bitmap);
+       if (Mcast_addr)
+               eth_mcast_join(Mcast_addr, 0);
+       if (Bitmap)
+               free(Bitmap);
        Bitmap = NULL;
        Mcast_addr = Multicast = Mcast_port = 0;
        TftpEndingBlock = -1;
@@ -145,8 +155,8 @@ mcast_cleanup(void)
 
 #endif /* CONFIG_MCAST_TFTP */
 
-static __inline__ void
-store_block(unsigned block, uchar *src, unsigned len)
+static inline void
+store_block(int block, uchar *src, unsigned len)
 {
        ulong offset = block * TftpBlkSize + TftpBlockWrapOffset;
        ulong newsize = offset + len;
@@ -167,11 +177,10 @@ store_block(unsigned block, uchar *src, unsigned len)
                rc = flash_write((char *)src, (ulong)(load_addr+offset), len);
                if (rc) {
                        flash_perror(rc);
-                       NetState = NETLOOP_FAIL;
+                       net_set_state(NETLOOP_FAIL);
                        return;
                }
-       }
-       else
+       } else
 #endif /* CONFIG_SYS_DIRECT_FLASH_TFTP */
        {
                (void)memcpy((void *)(load_addr + offset), src, len);
@@ -185,18 +194,122 @@ store_block(unsigned block, uchar *src, unsigned len)
                NetBootFileXferSize = newsize;
 }
 
+/* Clear our state ready for a new transfer */
+static void new_transfer(void)
+{
+       TftpLastBlock = 0;
+       TftpBlockWrap = 0;
+       TftpBlockWrapOffset = 0;
+#ifdef CONFIG_CMD_TFTPPUT
+       TftpFinalBlock = 0;
+#endif
+}
+
+#ifdef CONFIG_CMD_TFTPPUT
+/**
+ * Load the next block from memory to be sent over tftp.
+ *
+ * @param block        Block number to send
+ * @param dst  Destination buffer for data
+ * @param len  Number of bytes in block (this one and every other)
+ * @return number of bytes loaded
+ */
+static int load_block(unsigned block, uchar *dst, unsigned len)
+{
+       /* We may want to get the final block from the previous set */
+       ulong offset = ((int)block - 1) * len + TftpBlockWrapOffset;
+       ulong tosend = len;
+
+       tosend = min(NetBootFileXferSize - offset, tosend);
+       (void)memcpy(dst, (void *)(save_addr + offset), tosend);
+       debug("%s: block=%d, offset=%ld, len=%d, tosend=%ld\n", __func__,
+               block, offset, len, tosend);
+       return tosend;
+}
+#endif
+
 static void TftpSend(void);
 static void TftpTimeout(void);
 
 /**********************************************************************/
 
+static void show_block_marker(void)
+{
+#ifdef CONFIG_TFTP_TSIZE
+       if (TftpTsize) {
+               ulong pos = TftpBlock * TftpBlkSize + TftpBlockWrapOffset;
+
+               while (TftpNumchars < pos * 50 / TftpTsize) {
+                       putc('#');
+                       TftpNumchars++;
+               }
+       } else
+#endif
+       {
+               if (((TftpBlock - 1) % 10) == 0)
+                       putc('#');
+               else if ((TftpBlock % (10 * HASHES_PER_LINE)) == 0)
+                       puts("\n\t ");
+       }
+}
+
+/**
+ * restart the current transfer due to an error
+ *
+ * @param msg  Message to print for user
+ */
+static void restart(const char *msg)
+{
+       printf("\n%s; starting again\n", msg);
+#ifdef CONFIG_MCAST_TFTP
+       mcast_cleanup();
+#endif
+       NetStartAgain();
+}
+
+/*
+ * Check if the block number has wrapped, and update progress
+ *
+ * TODO: The egregious use of global variables in this file should be tidied.
+ */
+static void update_block_number(void)
+{
+       /*
+        * RFC1350 specifies that the first data packet will
+        * have sequence number 1. If we receive a sequence
+        * number of 0 this means that there was a wrap
+        * around of the (16 bit) counter.
+        */
+       if (TftpBlock == 0) {
+               TftpBlockWrap++;
+               TftpBlockWrapOffset += TftpBlkSize * TFTP_SEQUENCE_SIZE;
+               TftpTimeoutCount = 0; /* we've done well, reset thhe timeout */
+       } else {
+               show_block_marker();
+       }
+}
+
+/* The TFTP get or put is complete */
+static void tftp_complete(void)
+{
+#ifdef CONFIG_TFTP_TSIZE
+       /* Print hash marks for the last packet received */
+       while (TftpTsize && TftpNumchars < 49) {
+               putc('#');
+               TftpNumchars++;
+       }
+#endif
+       puts("\ndone\n");
+       net_set_state(NETLOOP_SUCCESS);
+}
+
 static void
 TftpSend(void)
 {
-       volatile uchar *pkt;
-       volatile uchar *xp;
-       int             len = 0;
-       volatile ushort *s;
+       uchar *pkt;
+       uchar *xp;
+       int len = 0;
+       ushort *s;
 
 #ifdef CONFIG_MCAST_TFTP
        /* Multicast TFTP.. non-MasterClients do not ACK data. */
@@ -209,14 +322,19 @@ TftpSend(void)
         *      We will always be sending some sort of packet, so
         *      cobble together the packet headers now.
         */
-       pkt = NetTxPacket + NetEthHdrSize() + IP_HDR_SIZE;
+       pkt = NetTxPacket + NetEthHdrSize() + IP_UDP_HDR_SIZE;
 
        switch (TftpState) {
-
-       case STATE_RRQ:
+       case STATE_SEND_RRQ:
+       case STATE_SEND_WRQ:
                xp = pkt;
                s = (ushort *)pkt;
+#ifdef CONFIG_CMD_TFTPPUT
+               *s++ = htons(TftpState == STATE_SEND_RRQ ? TFTP_RRQ :
+                       TFTP_WRQ);
+#else
                *s++ = htons(TFTP_RRQ);
+#endif
                pkt = (uchar *)s;
                strcpy((char *)pkt, tftp_filename);
                pkt += strlen(tftp_filename) + 1;
@@ -228,20 +346,22 @@ TftpSend(void)
                debug("send option \"timeout %s\"\n", (char *)pkt);
                pkt += strlen((char *)pkt) + 1;
 #ifdef CONFIG_TFTP_TSIZE
-               memcpy((char *)pkt, "tsize\0000\0", 8);
-               pkt += 8;
+               pkt += sprintf((char *)pkt, "tsize%c%lu%c",
+                               0, NetBootFileXferSize, 0);
 #endif
                /* try for more effic. blk size */
                pkt += sprintf((char *)pkt, "blksize%c%d%c",
                                0, TftpBlkSizeOption, 0);
 #ifdef CONFIG_MCAST_TFTP
                /* Check all preconditions before even trying the option */
-               if (!ProhibitMcast
-                && (Bitmap = malloc(Mapsize))
-                && eth_get_dev()->mcast) {
-                       free(Bitmap);
-                       Bitmap = NULL;
-                       pkt += sprintf((char *)pkt, "multicast%c%c", 0, 0);
+               if (!ProhibitMcast) {
+                       Bitmap = malloc(Mapsize);
+                       if (Bitmap && eth_get_dev()->mcast) {
+                               free(Bitmap);
+                               Bitmap = NULL;
+                               pkt += sprintf((char *)pkt, "multicast%c%c",
+                                       0, 0);
+                       }
                }
 #endif /* CONFIG_MCAST_TFTP */
                len = pkt - xp;
@@ -255,12 +375,24 @@ TftpSend(void)
                                                            (Mapsize*8), 0);
                /*..falling..*/
 #endif
+
+       case STATE_RECV_WRQ:
        case STATE_DATA:
                xp = pkt;
                s = (ushort *)pkt;
-               *s++ = htons(TFTP_ACK);
-               *s++ = htons(TftpBlock);
-               pkt = (uchar *)s;
+               s[0] = htons(TFTP_ACK);
+               s[1] = htons(TftpBlock);
+               pkt = (uchar *)(s + 2);
+#ifdef CONFIG_CMD_TFTPPUT
+               if (TftpWriting) {
+                       int toload = TftpBlkSize;
+                       int loaded = load_block(TftpBlock, pkt, toload);
+
+                       s[0] = htons(TFTP_DATA);
+                       pkt += loaded;
+                       TftpFinalBlock = (loaded < toload);
+               }
+#endif
                len = pkt - xp;
                break;
 
@@ -268,7 +400,8 @@ TftpSend(void)
                xp = pkt;
                s = (ushort *)pkt;
                *s++ = htons(TFTP_ERROR);
-               *s++ = htons(3);
+                       *s++ = htons(3);
+
                pkt = (uchar *)s;
                strcpy((char *)pkt, "File too large");
                pkt += 14 /*strlen("File too large")*/ + 1;
@@ -287,10 +420,20 @@ TftpSend(void)
                break;
        }
 
-       NetSendUDPPacket(NetServerEther, TftpServerIP, TftpServerPort,
+       NetSendUDPPacket(NetServerEther, TftpRemoteIP, TftpRemotePort,
                         TftpOurPort, len);
 }
 
+#ifdef CONFIG_CMD_TFTPPUT
+static void icmp_handler(unsigned type, unsigned code, unsigned dest,
+                        IPaddr_t sip, unsigned src, uchar *pkt, unsigned len)
+{
+       if (type == ICMP_NOT_REACH && code == ICMP_NOT_REACH_PORT) {
+               /* Oh dear the other end has gone away */
+               restart("TFTP server died");
+       }
+}
+#endif
 
 static void
 TftpHandler(uchar *pkt, unsigned dest, IPaddr_t sip, unsigned src,
@@ -305,15 +448,14 @@ TftpHandler(uchar *pkt, unsigned dest, IPaddr_t sip, unsigned src,
                if (Multicast
                 && (!Mcast_port || (dest != Mcast_port)))
 #endif
-               return;
+                       return;
        }
-       if (TftpState != STATE_RRQ && src != TftpServerPort) {
+       if (TftpState != STATE_SEND_RRQ && src != TftpRemotePort &&
+           TftpState != STATE_RECV_WRQ && TftpState != STATE_SEND_WRQ)
                return;
-       }
 
-       if (len < 2) {
+       if (len < 2)
                return;
-       }
        len -= 2;
        /* warning: don't use increment (++) in ntohs() macros!! */
        s = (ushort *)pkt;
@@ -322,18 +464,50 @@ TftpHandler(uchar *pkt, unsigned dest, IPaddr_t sip, unsigned src,
        switch (ntohs(proto)) {
 
        case TFTP_RRQ:
-       case TFTP_WRQ:
+               break;
+
        case TFTP_ACK:
+#ifdef CONFIG_CMD_TFTPPUT
+               if (TftpWriting) {
+                       if (TftpFinalBlock) {
+                               tftp_complete();
+                       } else {
+                               /*
+                                * Move to the next block. We want our block
+                                * count to wrap just like the other end!
+                                */
+                               int block = ntohs(*s);
+                               int ack_ok = (TftpBlock == block);
+
+                               TftpBlock = (unsigned short)(block + 1);
+                               update_block_number();
+                               if (ack_ok)
+                                       TftpSend(); /* Send next data block */
+                       }
+               }
+#endif
                break;
+
        default:
                break;
 
+#ifdef CONFIG_CMD_TFTPSRV
+       case TFTP_WRQ:
+               debug("Got WRQ\n");
+               TftpRemoteIP = sip;
+               TftpRemotePort = src;
+               TftpOurPort = 1024 + (get_timer(0) % 3072);
+               new_transfer();
+               TftpSend(); /* Send ACK(0) */
+               break;
+#endif
+
        case TFTP_OACK:
                debug("Got OACK: %s %s\n",
                        pkt,
                        pkt + strlen((char *)pkt) + 1);
                TftpState = STATE_OACK;
-               TftpServerPort = src;
+               TftpRemotePort = src;
                /*
                 * Check for 'blksize' option.
                 * Careful: "i" is signed, "len" is unsigned, thus
@@ -362,7 +536,14 @@ TftpHandler(uchar *pkt, unsigned dest, IPaddr_t sip, unsigned src,
                        TftpState = STATE_DATA; /* passive.. */
                else
 #endif
-               TftpSend(); /* Send ACK */
+#ifdef CONFIG_CMD_TFTPPUT
+               if (TftpWriting) {
+                       /* Get ready to send the first block */
+                       TftpState = STATE_DATA;
+                       TftpBlock++;
+               }
+#endif
+               TftpSend(); /* Send ACK or first data block */
                break;
        case TFTP_DATA:
                if (len < 2)
@@ -370,46 +551,17 @@ TftpHandler(uchar *pkt, unsigned dest, IPaddr_t sip, unsigned src,
                len -= 2;
                TftpBlock = ntohs(*(ushort *)pkt);
 
-               /*
-                * RFC1350 specifies that the first data packet will
-                * have sequence number 1. If we receive a sequence
-                * number of 0 this means that there was a wrap
-                * around of the (16 bit) counter.
-                */
-               if (TftpBlock == 0) {
-                       TftpBlockWrap++;
-                       TftpBlockWrapOffset +=
-                               TftpBlkSize * TFTP_SEQUENCE_SIZE;
-                       printf("\n\t %lu MB received\n\t ",
-                               TftpBlockWrapOffset>>20);
-               }
-#ifdef CONFIG_TFTP_TSIZE
-               else if (TftpTsize) {
-                       while (TftpNumchars <
-                              NetBootFileXferSize * 50 / TftpTsize) {
-                               putc('#');
-                               TftpNumchars++;
-                       }
-               }
-#endif
-               else {
-                       if (((TftpBlock - 1) % 10) == 0) {
-                               putc('#');
-                       } else if ((TftpBlock % (10 * HASHES_PER_LINE)) == 0) {
-                               puts("\n\t ");
-                       }
-               }
+               update_block_number();
 
-               if (TftpState == STATE_RRQ)
+               if (TftpState == STATE_SEND_RRQ)
                        debug("Server did not acknowledge timeout option!\n");
 
-               if (TftpState == STATE_RRQ || TftpState == STATE_OACK) {
+               if (TftpState == STATE_SEND_RRQ || TftpState == STATE_OACK ||
+                   TftpState == STATE_RECV_WRQ) {
                        /* first block received */
                        TftpState = STATE_DATA;
-                       TftpServerPort = src;
-                       TftpLastBlock = 0;
-                       TftpBlockWrap = 0;
-                       TftpBlockWrapOffset = 0;
+                       TftpRemotePort = src;
+                       new_transfer();
 
 #ifdef CONFIG_MCAST_TFTP
                        if (Multicast) { /* start!=1 common if mcast */
@@ -440,8 +592,8 @@ TftpHandler(uchar *pkt, unsigned dest, IPaddr_t sip, unsigned src,
                store_block(TftpBlock - 1, pkt + 2, len);
 
                /*
-                *      Acknoledge the block just received, which will prompt
-                *      the server for the next one.
+                *      Acknowledge the block just received, which will prompt
+                *      the remote for the next one.
                 */
 #ifdef CONFIG_MCAST_TFTP
                /* if I am the MasterClient, actively calculate what my next
@@ -475,26 +627,12 @@ TftpHandler(uchar *pkt, unsigned dest, IPaddr_t sip, unsigned src,
                        if (MasterClient && (TftpBlock >= TftpEndingBlock)) {
                                puts("\nMulticast tftp done\n");
                                mcast_cleanup();
-                               NetState = NETLOOP_SUCCESS;
+                               net_set_state(NETLOOP_SUCCESS);
                        }
-               }
-               else
+               } else
 #endif
-               if (len < TftpBlkSize) {
-                       /*
-                        *      We received the whole thing.  Try to
-                        *      run it.
-                        */
-#ifdef CONFIG_TFTP_TSIZE
-                       /* Print hash marks for the last packet received */
-                       while (TftpTsize && TftpNumchars < 49) {
-                               putc('#');
-                               TftpNumchars++;
-                       }
-#endif
-                       puts("\ndone\n");
-                       NetState = NETLOOP_SUCCESS;
-               }
+               if (len < TftpBlkSize)
+                       tftp_complete();
                break;
 
        case TFTP_ERROR:
@@ -506,7 +644,7 @@ TftpHandler(uchar *pkt, unsigned dest, IPaddr_t sip, unsigned src,
                case TFTP_ERR_ACCESS_DENIED:
                        puts("Not retrying...\n");
                        eth_halt();
-                       NetState = NETLOOP_FAIL;
+                       net_set_state(NETLOOP_FAIL);
                        break;
                case TFTP_ERR_UNDEFINED:
                case TFTP_ERR_DISK_FULL:
@@ -530,21 +668,17 @@ static void
 TftpTimeout(void)
 {
        if (++TftpTimeoutCount > TftpTimeoutCountMax) {
-               puts("\nRetry count exceeded; starting again\n");
-#ifdef CONFIG_MCAST_TFTP
-               mcast_cleanup();
-#endif
-               NetStartAgain();
+               restart("Retry count exceeded");
        } else {
                puts("T ");
                NetSetTimeout(TftpTimeoutMSecs, TftpTimeout);
-               TftpSend();
+               if (TftpState != STATE_RECV_WRQ)
+                       TftpSend();
        }
 }
 
 
-void
-TftpStart(void)
+void TftpStart(enum proto_t protocol)
 {
        char *ep;             /* Environment pointer */
 
@@ -552,10 +686,12 @@ TftpStart(void)
         * Allow the user to choose TFTP blocksize and timeout.
         * TFTP protocol has a minimal timeout of 1 second.
         */
-       if ((ep = getenv("tftpblocksize")) != NULL)
+       ep = getenv("tftpblocksize");
+       if (ep != NULL)
                TftpBlkSizeOption = simple_strtol(ep, NULL, 10);
 
-       if ((ep = getenv("tftptimeout")) != NULL)
+       ep = getenv("tftptimeout");
+       if (ep != NULL)
                TftpTimeoutMSecs = simple_strtol(ep, NULL, 10);
 
        if (TftpTimeoutMSecs < 1000) {
@@ -568,9 +704,9 @@ TftpStart(void)
        debug("TFTP blocksize = %i, timeout = %ld ms\n",
                TftpBlkSizeOption, TftpTimeoutMSecs);
 
-       TftpServerIP = NetServerIP;
+       TftpRemoteIP = NetServerIP;
        if (BootFile[0] == '\0') {
-               sprintf(default_filename, "%02lX%02lX%02lX%02lX.img",
+               sprintf(default_filename, "%02X%02X%02X%02X.img",
                        NetOurIP & 0xFF,
                        (NetOurIP >>  8) & 0xFF,
                        (NetOurIP >> 16) & 0xFF,
@@ -588,25 +724,29 @@ TftpStart(void)
                        strncpy(tftp_filename, BootFile, MAX_LEN);
                        tftp_filename[MAX_LEN-1] = 0;
                } else {
-                       TftpServerIP = string_to_ip(BootFile);
+                       TftpRemoteIP = string_to_ip(BootFile);
                        strncpy(tftp_filename, p + 1, MAX_LEN);
                        tftp_filename[MAX_LEN-1] = 0;
                }
        }
 
-#if defined(CONFIG_NET_MULTI)
        printf("Using %s device\n", eth_get_name());
+       printf("TFTP %s server %pI4; our IP address is %pI4",
+#ifdef CONFIG_CMD_TFTPPUT
+              protocol == TFTPPUT ? "to" : "from",
+#else
+               "from",
 #endif
-       printf("TFTP from server %pI4"
-               "; our IP address is %pI4", &TftpServerIP, &NetOurIP);
+               &TftpRemoteIP, &NetOurIP);
 
        /* Check if we need to send across this subnet */
        if (NetOurGatewayIP && NetOurSubnetMask) {
-           IPaddr_t OurNet     = NetOurIP    & NetOurSubnetMask;
-           IPaddr_t ServerNet  = TftpServerIP & NetOurSubnetMask;
+               IPaddr_t OurNet = NetOurIP    & NetOurSubnetMask;
+               IPaddr_t RemoteNet      = TftpRemoteIP & NetOurSubnetMask;
 
-           if (OurNet != ServerNet)
-               printf("; sending through gateway %pI4", &NetOurGatewayIP);
+               if (OurNet != RemoteNet)
+                       printf("; sending through gateway %pI4",
+                              &NetOurGatewayIP);
        }
        putc('\n');
 
@@ -618,29 +758,42 @@ TftpStart(void)
        }
 
        putc('\n');
-
-       printf("Load address: 0x%lx\n", load_addr);
-
-       puts("Loading: *\b");
+#ifdef CONFIG_CMD_TFTPPUT
+       TftpWriting = (protocol == TFTPPUT);
+       if (TftpWriting) {
+               printf("Save address: 0x%lx\n", save_addr);
+               printf("Save size:    0x%lx\n", save_size);
+               NetBootFileXferSize = save_size;
+               puts("Saving: *\b");
+               TftpState = STATE_SEND_WRQ;
+               new_transfer();
+       } else
+#endif
+       {
+               printf("Load address: 0x%lx\n", load_addr);
+               puts("Loading: *\b");
+               TftpState = STATE_SEND_RRQ;
+       }
 
        TftpTimeoutCountMax = TftpRRQTimeoutCountMax;
 
        NetSetTimeout(TftpTimeoutMSecs, TftpTimeout);
-       NetSetHandler(TftpHandler);
-
-       TftpServerPort = WELL_KNOWN_PORT;
+       net_set_udp_handler(TftpHandler);
+#ifdef CONFIG_CMD_TFTPPUT
+       net_set_icmp_handler(icmp_handler);
+#endif
+       TftpRemotePort = WELL_KNOWN_PORT;
        TftpTimeoutCount = 0;
-       TftpState = STATE_RRQ;
        /* Use a pseudo-random port unless a specific port is set */
        TftpOurPort = 1024 + (get_timer(0) % 3072);
 
 #ifdef CONFIG_TFTP_PORT
-       if ((ep = getenv("tftpdstp")) != NULL) {
-               TftpServerPort = simple_strtol(ep, NULL, 10);
-       }
-       if ((ep = getenv("tftpsrcp")) != NULL) {
+       ep = getenv("tftpdstp");
+       if (ep != NULL)
+               TftpRemotePort = simple_strtol(ep, NULL, 10);
+       ep = getenv("tftpsrcp");
+       if (ep != NULL)
                TftpOurPort = simple_strtol(ep, NULL, 10);
-       }
 #endif
        TftpBlock = 0;
 
@@ -659,6 +812,38 @@ TftpStart(void)
        TftpSend();
 }
 
+#ifdef CONFIG_CMD_TFTPSRV
+void
+TftpStartServer(void)
+{
+       tftp_filename[0] = 0;
+
+       printf("Using %s device\n", eth_get_name());
+       printf("Listening for TFTP transfer on %pI4\n", &NetOurIP);
+       printf("Load address: 0x%lx\n", load_addr);
+
+       puts("Loading: *\b");
+
+       TftpTimeoutCountMax = TIMEOUT_COUNT;
+       TftpTimeoutCount = 0;
+       TftpTimeoutMSecs = TIMEOUT;
+       NetSetTimeout(TftpTimeoutMSecs, TftpTimeout);
+
+       /* Revert TftpBlkSize to dflt */
+       TftpBlkSize = TFTP_BLOCK_SIZE;
+       TftpBlock = 0;
+       TftpOurPort = WELL_KNOWN_PORT;
+
+#ifdef CONFIG_TFTP_TSIZE
+       TftpTsize = 0;
+       TftpNumchars = 0;
+#endif
+
+       TftpState = STATE_RECV_WRQ;
+       net_set_udp_handler(TftpHandler);
+}
+#endif /* CONFIG_CMD_TFTPSRV */
+
 #ifdef CONFIG_MCAST_TFTP
 /* Credits: atftp project.
  */
@@ -704,7 +889,8 @@ static void parse_multicast_oack(char *pkt, int len)
                        }
                }
        }
-       if (!port || !mc_adr || !mc) return;
+       if (!port || !mc_adr || !mc)
+               return;
        if (Multicast && MasterClient) {
                printf("I got a OACK as master Client, WRONG!\n");
                return;
@@ -721,7 +907,8 @@ static void parse_multicast_oack(char *pkt, int len)
                /* I malloc instead of pre-declare; so that if the file ends
                 * up being too big for this bitmap I can retry
                 */
-               if (!(Bitmap = malloc(Mapsize))) {
+               Bitmap = malloc(Mapsize);
+               if (!Bitmap) {
                        printf("No Bitmap, no multicast. Sorry.\n");
                        ProhibitMcast = 1;
                        return;
@@ -734,7 +921,8 @@ static void parse_multicast_oack(char *pkt, int len)
        if (Mcast_addr != addr) {
                if (Mcast_addr)
                        eth_mcast_join(Mcast_addr, 0);
-               if (eth_mcast_join(Mcast_addr = addr, 1)) {
+               Mcast_addr = addr;
+               if (eth_mcast_join(Mcast_addr, 1)) {
                        printf("Fail to set mcast, revert to TFTP\n");
                        ProhibitMcast = 1;
                        mcast_cleanup();