]> git.kernelconcepts.de Git - karo-tx-uboot.git/commit
malloc_simple: Return NULL on malloc failure rather then calling panic()
authorHans de Goede <hdegoede@redhat.com>
Wed, 4 Feb 2015 12:05:50 +0000 (13:05 +0100)
committerLothar Waßmann <LW@KARO-electronics.de>
Tue, 1 Sep 2015 11:50:44 +0000 (13:50 +0200)
commit05eabb48bf0d083e13083a3f22a9d2b238a7e534
tree966062e4a3be4c6d6138361c2cc6c6aebed32d16
parentdf3656258c13dcb60b897ab56a3a0cae0855a5ff
malloc_simple: Return NULL on malloc failure rather then calling panic()

All callers of malloc should already do error checking, and may even be able
to continue without the alloc succeeding.

Moreover, common/malloc_simple.c is the only user of .rodata.str1.1 in
common/built-in.o when building the SPL, triggering this gcc bug:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=54303

Causing .rodata to grow with e.g. 0xc21 bytes, nullifying all benefits of
using malloc_simple in the first place.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Simon Glass <sjg@chromium.org>
common/malloc_simple.c