]> git.kernelconcepts.de Git - karo-tx-uboot.git/commit
rm9200 lowevel_init: don't touch reserved/readonly registers
authorDavid Brownell <david-b@pacbell.net>
Fri, 17 Jul 2009 01:40:55 +0000 (18:40 -0700)
committerJean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Mon, 3 Aug 2009 07:26:26 +0000 (09:26 +0200)
commit06bffc6ea52d4b390843d295d438b2037d12e5fd
tree689ea76a23daa57493debfc4fbbf11984bab7271
parent301b7db88fbdf7d118efb79b371b2527a2c31868
rm9200 lowevel_init: don't touch reserved/readonly registers

For some reason the AT91rm9200 lowlevel init writes to a bunch of
reserved or read-only addresses.  All the boards seem to define the
value-to-be-written values as zero ... but they shouldn't actually
be writing *anything* there.

No documented erratum justifies these accesses.  It looks like maybe
some pre-release BDI-2000 setup code has been carried along by cargo
cult programming since at least late 2004 (per GIT history).

Here's a patch disabling what seems to be bogosity.  Tested on a
csb337; there were no behavioral changes.

Signed-off-by: David Brownell <david-b@pacbell.net>
on RM9200ek
Tested-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
cpu/arm920t/at91rm9200/lowlevel_init.S
include/configs/at91rm9200dk.h
include/configs/at91rm9200ek.h
include/configs/cmc_pu2.h
include/configs/csb637.h
include/configs/m501sk.h
include/configs/mp2usb.h