]> git.kernelconcepts.de Git - karo-tx-uboot.git/commit
sunxi: rsb: Enable R_PIO clock before configuring external pins
authorChen-Yu Tsai <wens@csie.org>
Tue, 23 Jun 2015 11:57:24 +0000 (19:57 +0800)
committerLothar Waßmann <LW@KARO-electronics.de>
Tue, 8 Sep 2015 22:47:36 +0000 (00:47 +0200)
commitf28995bf041a6b011171bf62f2703a7efa6ae909
treebc5774094b7b31b5a73ff6be1df74cd729da5989
parent42dfe044305bd6d1633e5fd59ba4fea3739e79d1
sunxi: rsb: Enable R_PIO clock before configuring external pins

The original code was configuring the external pins after enabling
the R_PIO clock, which meant the configuration never made it to
the pin controller the first time in SPL.

Why this was working before is uncertain. Maybe the state was left
from a previous boot sequence, or RSB just happened to be the default
configuration. However with some A33 chips, SPL failed to configure
the PMIC. This was seen by me and Maxime on the Sinlinx SinA33 dev
board.

Reordering the calls fixed this.

Signed-off-by: Chen-Yu Tsai <wens@csie.org>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
Tested-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
arch/arm/cpu/armv7/sunxi/rsb.c