]> git.kernelconcepts.de Git - karo-tx-uboot.git/commitdiff
dm: sandbox: sf: Tidy up the error handling in sandbox_sf_probe()
authorSimon Glass <sjg@chromium.org>
Sun, 25 Jan 2015 15:27:09 +0000 (08:27 -0700)
committerSimon Glass <sjg@chromium.org>
Fri, 30 Jan 2015 00:09:56 +0000 (17:09 -0700)
Use a single exit point when we have an error and add debugging there.

Signed-off-by: Simon Glass <sjg@chromium.org>
drivers/mtd/spi/sandbox.c

index 3024b988fef904884f4d6e4920d98859714f115c..106dda9ccc52b8850f84d0575b774537dab0c6e9 100644 (file)
@@ -141,8 +141,10 @@ static int sandbox_sf_probe(struct udevice *dev)
                assert(bus->seq != -1);
                if (bus->seq < CONFIG_SANDBOX_SPI_MAX_BUS)
                        spec = state->spi[bus->seq][cs].spec;
-               if (!spec)
-                       return -ENOENT;
+               if (!spec) {
+                       ret = -ENOENT;
+                       goto error;
+               }
 
                file = strchr(spec, ':');
                if (!file) {
@@ -196,6 +198,7 @@ static int sandbox_sf_probe(struct udevice *dev)
        return 0;
 
  error:
+       debug("%s: Got error %d\n", __func__, ret);
        return ret;
 }