]> git.kernelconcepts.de Git - karo-tx-uboot.git/commitdiff
x86: gpio: Correct calls to _ich6_gpio_set_direction()
authorSimon Glass <sjg@chromium.org>
Sat, 22 Aug 2015 21:58:58 +0000 (15:58 -0600)
committerLothar Waßmann <LW@KARO-electronics.de>
Thu, 10 Sep 2015 09:29:47 +0000 (11:29 +0200)
These calls seem to be incorrect. The function expects an I/O address but
the existing callers pass the value at an I/O address. Fix it.

Signed-off-by: Simon Glass <sjg@chromium.org>
drivers/gpio/intel_ich6_gpio.c

index cb408a413e647c2861af3d600768d75a1b198895..fd1f28703fb46e5c5398dfd43dba0584c532e134 100644 (file)
@@ -410,7 +410,7 @@ static int ich6_gpio_direction_input(struct udevice *dev, unsigned offset)
 {
        struct ich6_bank_priv *bank = dev_get_priv(dev);
 
-       return _ich6_gpio_set_direction(inl(bank->io_sel), offset, 0);
+       return _ich6_gpio_set_direction(bank->io_sel, offset, 0);
 }
 
 static int ich6_gpio_direction_output(struct udevice *dev, unsigned offset,
@@ -419,7 +419,7 @@ static int ich6_gpio_direction_output(struct udevice *dev, unsigned offset,
        int ret;
        struct ich6_bank_priv *bank = dev_get_priv(dev);
 
-       ret = _ich6_gpio_set_direction(inl(bank->io_sel), offset, 1);
+       ret = _ich6_gpio_set_direction(bank->io_sel, offset, 1);
        if (ret)
                return ret;