gpio: use appropriate return values for cmd handler

[karo-tx-uboot.git] / common / cmd_cache.c

diff --git a/common/cmd_cache.c b/common/cmd_cache.c
index 0dfa3363bdd754e4dbac3ddadb339c497acffeb2..37ab345cb6c17ab059015010e9be6750ac84064e 100644 (file)
--- a/common/cmd_cache.c
+++ b/common/cmd_cache.c
@@ -2,23 +2,7 @@
  * (C) Copyright 2000
  * Wolfgang Denk, DENX Software Engineering, wd@denx.de.
  *
- * See file CREDITS for list of people who contributed to this
- * project.
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License as
- * published by the Free Software Foundation; either version 2 of
- * the License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
- * MA 02111-1307 USA
+ * SPDX-License-Identifier:    GPL-2.0+
  */
 
 /*
@@ -26,87 +10,97 @@
  */
 #include <common.h>
 #include <command.h>
+#include <linux/compiler.h>
 
-#if defined(CONFIG_CMD_CACHE)
+static int parse_argv(const char *);
 
-static int on_off (const char *);
+void __weak invalidate_icache_all(void)
+{
+       /* please define arch specific invalidate_icache_all */
+       puts("No arch specific invalidate_icache_all available!\n");
+}
 
-int do_icache ( cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
+static int do_icache(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 {
        switch (argc) {
        case 2:                 /* on / off     */
-               switch (on_off(argv[1])) {
-#if 0  /* prevented by varargs handling; FALLTROUGH is harmless, too */
-               default: cmd_usage(cmdtp);
-                       return;
-#endif
-               case 0: icache_disable();
+               switch (parse_argv(argv[1])) {
+               case 0:
+                       icache_disable();
                        break;
-               case 1: icache_enable ();
+               case 1:
+                       icache_enable();
+                       break;
+               case 2:
+                       invalidate_icache_all();
                        break;
                }
-               /* FALL TROUGH */
+               break;
        case 1:                 /* get status */
-               printf ("Instruction Cache is %s\n",
+               printf("Instruction Cache is %s\n",
                        icache_status() ? "ON" : "OFF");
                return 0;
        default:
-               cmd_usage(cmdtp);
-               return 1;
+               return CMD_RET_USAGE;
        }
        return 0;
 }
 
-int do_dcache ( cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
+void __weak flush_dcache_all(void)
+{
+       puts("No arch specific flush_dcache_all available!\n");
+       /* please define arch specific flush_dcache_all */
+}
+
+static int do_dcache(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 {
        switch (argc) {
-       case 2:                 /* on / off     */
-               switch (on_off(argv[1])) {
-#if 0  /* prevented by varargs handling; FALLTROUGH is harmless, too */
-               default: cmd_usage(cmdtp);
-                       return;
-#endif
-               case 0: dcache_disable();
+       case 2:                 /* on / off */
+               switch (parse_argv(argv[1])) {
+               case 0:
+                       dcache_disable();
+                       break;
+               case 1:
+                       dcache_enable();
                        break;
-               case 1: dcache_enable ();
+               case 2:
+                       flush_dcache_all();
                        break;
                }
-               /* FALL TROUGH */
+               break;
        case 1:                 /* get status */
-               printf ("Data (writethrough) Cache is %s\n",
+               printf("Data (writethrough) Cache is %s\n",
                        dcache_status() ? "ON" : "OFF");
                return 0;
        default:
-               cmd_usage(cmdtp);
-               return 1;
+               return CMD_RET_USAGE;
        }
        return 0;
-
 }
 
-static int on_off (const char *s)
+static int parse_argv(const char *s)
 {
-       if (strcmp(s, "on") == 0) {
-               return (1);
-       } else if (strcmp(s, "off") == 0) {
-               return (0);
-       }
-       return (-1);
+       if (strcmp(s, "flush") == 0)
+               return 2;
+       else if (strcmp(s, "on") == 0)
+               return 1;
+       else if (strcmp(s, "off") == 0)
+               return 0;
+
+       return -1;
 }
 
 
 U_BOOT_CMD(
        icache,   2,   1,     do_icache,
        "enable or disable instruction cache",
-       "[on, off]\n"
-       "    - enable or disable instruction cache"
+       "[on, off, flush]\n"
+       "    - enable, disable, or flush instruction cache"
 );
 
 U_BOOT_CMD(
        dcache,   2,   1,     do_dcache,
        "enable or disable data cache",
-       "[on, off]\n"
-       "    - enable or disable data (writethrough) cache"
+       "[on, off, flush]\n"
+       "    - enable, disable, or flush data (writethrough) cache"
 );
-
-#endif