]> git.kernelconcepts.de Git - karo-tx-uboot.git/blobdiff - test/dm/test-fdt.c
dm: core: Allow uclass to set up a device's child before it is probed
[karo-tx-uboot.git] / test / dm / test-fdt.c
index 98e3936527ea11a594f4abd215c86b9fdfaf01ba..b8ee9599a22a67c999bb8cd066226cf63237f324 100644 (file)
@@ -39,7 +39,8 @@ static int testfdt_ofdata_to_platdata(struct udevice *dev)
 
        pdata->ping_add = fdtdec_get_int(gd->fdt_blob, dev->of_offset,
                                        "ping-add", -1);
-       pdata->base = fdtdec_get_addr(gd->fdt_blob, dev->of_offset, "reg");
+       pdata->base = fdtdec_get_addr(gd->fdt_blob, dev->of_offset,
+                                     "ping-expect");
 
        return 0;
 }
@@ -50,6 +51,13 @@ static int testfdt_drv_probe(struct udevice *dev)
 
        priv->ping_total += DM_TEST_START_TOTAL;
 
+       /*
+        * If this device is on a bus, the uclass_flag will be set before
+        * calling this function. This is used by
+        * dm_test_bus_child_pre_probe_uclass().
+        */
+       priv->uclass_total += priv->uclass_flag;
+
        return 0;
 }
 
@@ -88,57 +96,173 @@ int testfdt_ping(struct udevice *dev, int pingval, int *pingret)
 UCLASS_DRIVER(testfdt) = {
        .name           = "testfdt",
        .id             = UCLASS_TEST_FDT,
+       .flags          = DM_UC_FLAG_SEQ_ALIAS,
 };
 
+int dm_check_devices(struct dm_test_state *dms, int num_devices)
+{
+       struct udevice *dev;
+       int ret;
+       int i;
+
+       /*
+        * Now check that the ping adds are what we expect. This is using the
+        * ping-add property in each node.
+        */
+       for (i = 0; i < num_devices; i++) {
+               uint32_t base;
+
+               ret = uclass_get_device(UCLASS_TEST_FDT, i, &dev);
+               ut_assert(!ret);
+
+               /*
+                * Get the 'ping-expect' property, which tells us what the
+                * ping add should be. We don't use the platdata because we
+                * want to test the code that sets that up
+                * (testfdt_drv_probe()).
+                */
+               base = fdtdec_get_addr(gd->fdt_blob, dev->of_offset,
+                                      "ping-expect");
+               debug("dev=%d, base=%d: %s\n", i, base,
+                     fdt_get_name(gd->fdt_blob, dev->of_offset, NULL));
+
+               ut_assert(!dm_check_operations(dms, dev, base,
+                                              dev_get_priv(dev)));
+       }
+
+       return 0;
+}
+
 /* Test that FDT-based binding works correctly */
 static int dm_test_fdt(struct dm_test_state *dms)
 {
-       const int num_drivers = 3;
+       const int num_devices = 6;
        struct udevice *dev;
        struct uclass *uc;
        int ret;
        int i;
 
-       ret = dm_scan_fdt(gd->fdt_blob);
+       ret = dm_scan_fdt(gd->fdt_blob, false);
        ut_assert(!ret);
 
        ret = uclass_get(UCLASS_TEST_FDT, &uc);
        ut_assert(!ret);
 
-       /* These are num_drivers compatible root-level device tree nodes */
-       ut_asserteq(num_drivers, list_count_items(&uc->dev_head));
+       /* These are num_devices compatible root-level device tree nodes */
+       ut_asserteq(num_devices, list_count_items(&uc->dev_head));
 
-       /* Each should have no platdata / priv */
-       for (i = 0; i < num_drivers; i++) {
+       /* Each should have platform data but no private data */
+       for (i = 0; i < num_devices; i++) {
                ret = uclass_find_device(UCLASS_TEST_FDT, i, &dev);
                ut_assert(!ret);
                ut_assert(!dev_get_priv(dev));
-               ut_assert(!dev->platdata);
+               ut_assert(dev->platdata);
        }
 
+       ut_assertok(dm_check_devices(dms, num_devices));
+
+       return 0;
+}
+DM_TEST(dm_test_fdt, 0);
+
+static int dm_test_fdt_pre_reloc(struct dm_test_state *dms)
+{
+       struct uclass *uc;
+       int ret;
+
+       ret = dm_scan_fdt(gd->fdt_blob, true);
+       ut_assert(!ret);
+
+       ret = uclass_get(UCLASS_TEST_FDT, &uc);
+       ut_assert(!ret);
+
+       /* These is only one pre-reloc device */
+       ut_asserteq(1, list_count_items(&uc->dev_head));
+
+       return 0;
+}
+DM_TEST(dm_test_fdt_pre_reloc, 0);
+
+/* Test that sequence numbers are allocated properly */
+static int dm_test_fdt_uclass_seq(struct dm_test_state *dms)
+{
+       struct udevice *dev;
+
+       /* A few basic santiy tests */
+       ut_assertok(uclass_find_device_by_seq(UCLASS_TEST_FDT, 3, true, &dev));
+       ut_asserteq_str("b-test", dev->name);
+
+       ut_assertok(uclass_find_device_by_seq(UCLASS_TEST_FDT, 8, true, &dev));
+       ut_asserteq_str("a-test", dev->name);
+
+       ut_asserteq(-ENODEV, uclass_find_device_by_seq(UCLASS_TEST_FDT, 5,
+                                                      true, &dev));
+       ut_asserteq_ptr(NULL, dev);
+
+       /* Test aliases */
+       ut_assertok(uclass_get_device_by_seq(UCLASS_TEST_FDT, 6, &dev));
+       ut_asserteq_str("e-test", dev->name);
+
+       ut_asserteq(-ENODEV, uclass_find_device_by_seq(UCLASS_TEST_FDT, 7,
+                                                      true, &dev));
+
        /*
-        * Now check that the ping adds are what we expect. This is using the
-        * ping-add property in each node.
+        * Note that c-test nodes are not probed since it is not a top-level
+        * node
         */
-       for (i = 0; i < num_drivers; i++) {
-               uint32_t base;
+       ut_assertok(uclass_get_device_by_seq(UCLASS_TEST_FDT, 3, &dev));
+       ut_asserteq_str("b-test", dev->name);
 
-               ret = uclass_get_device(UCLASS_TEST_FDT, i, &dev);
-               ut_assert(!ret);
+       /*
+        * d-test wants sequence number 3 also, but it can't have it because
+        * b-test gets it first.
+        */
+       ut_assertok(uclass_get_device(UCLASS_TEST_FDT, 2, &dev));
+       ut_asserteq_str("d-test", dev->name);
 
-               /*
-                * Get the 'reg' property, which tells us what the ping add
-                * should be. We don't use the platdata because we want
-                * to test the code that sets that up (testfdt_drv_probe()).
-                */
-               base = fdtdec_get_addr(gd->fdt_blob, dev->of_offset, "reg");
-               debug("dev=%d, base=%d: %s\n", i, base,
-                     fdt_get_name(gd->fdt_blob, dev->of_offset, NULL));
+       /* d-test actually gets 0 */
+       ut_assertok(uclass_get_device_by_seq(UCLASS_TEST_FDT, 0, &dev));
+       ut_asserteq_str("d-test", dev->name);
 
-               ut_assert(!dm_check_operations(dms, dev, base,
-                                              dev_get_priv(dev)));
-       }
+       /* initially no one wants seq 1 */
+       ut_asserteq(-ENODEV, uclass_get_device_by_seq(UCLASS_TEST_FDT, 1,
+                                                     &dev));
+       ut_assertok(uclass_get_device(UCLASS_TEST_FDT, 0, &dev));
+       ut_assertok(uclass_get_device(UCLASS_TEST_FDT, 4, &dev));
+
+       /* But now that it is probed, we can find it */
+       ut_assertok(uclass_get_device_by_seq(UCLASS_TEST_FDT, 1, &dev));
+       ut_asserteq_str("f-test", dev->name);
 
        return 0;
 }
-DM_TEST(dm_test_fdt, 0);
+DM_TEST(dm_test_fdt_uclass_seq, DM_TESTF_SCAN_PDATA | DM_TESTF_SCAN_FDT);
+
+/* Test that we can find a device by device tree offset */
+static int dm_test_fdt_offset(struct dm_test_state *dms)
+{
+       const void *blob = gd->fdt_blob;
+       struct udevice *dev;
+       int node;
+
+       node = fdt_path_offset(blob, "/e-test");
+       ut_assert(node > 0);
+       ut_assertok(uclass_get_device_by_of_offset(UCLASS_TEST_FDT, node,
+                                                  &dev));
+       ut_asserteq_str("e-test", dev->name);
+
+       /* This node should not be bound */
+       node = fdt_path_offset(blob, "/junk");
+       ut_assert(node > 0);
+       ut_asserteq(-ENODEV, uclass_get_device_by_of_offset(UCLASS_TEST_FDT,
+                                                           node, &dev));
+
+       /* This is not a top level node so should not be probed */
+       node = fdt_path_offset(blob, "/some-bus/c-test@5");
+       ut_assert(node > 0);
+       ut_asserteq(-ENODEV, uclass_get_device_by_of_offset(UCLASS_TEST_FDT,
+                                                           node, &dev));
+
+       return 0;
+}
+DM_TEST(dm_test_fdt_offset, DM_TESTF_SCAN_PDATA | DM_TESTF_SCAN_FDT);