]> git.kernelconcepts.de Git - karo-tx-uboot.git/commitdiff
exynos: spi: Convert the timeout to debug()
authorSimon Glass <sjg@chromium.org>
Fri, 3 Jul 2015 00:16:11 +0000 (18:16 -0600)
committerLothar Waßmann <LW@KARO-electronics.de>
Thu, 10 Sep 2015 06:17:15 +0000 (08:17 +0200)
Since the timeout is reported through normal channels, and is sometimes
expected (e.g. if the bus is being probed for a non-existent device),
don't display the message in the driver.

In general, drivers should not write to the console as this limits their
usefulness in error conditions.

Signed-off-by: Simon Glass <sjg@chromium.org>
drivers/spi/exynos_spi.c

index 67f6b2d7cdaa871b97f170d78476c658a622a94e..6d77c319e7e3c43edec455576dddb57f9d009cb0 100644 (file)
@@ -190,9 +190,9 @@ static int spi_rx_tx(struct exynos_spi_priv *priv, int todo,
                        spi_request_bytes(regs, toread, step);
                }
                if (priv->skip_preamble && get_timer(start) > 100) {
-                       printf("SPI timeout: in_bytes=%d, out_bytes=%d, ",
-                              in_bytes, out_bytes);
-                       return -1;
+                       debug("SPI timeout: in_bytes=%d, out_bytes=%d, ",
+                             in_bytes, out_bytes);
+                       return -ETIMEDOUT;
                }
        }