]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
HID: i2c-hid: fix harmless test_bit() issue
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 14 May 2015 08:33:30 +0000 (11:33 +0300)
committerJiri Kosina <jkosina@suse.cz>
Mon, 18 May 2015 09:22:53 +0000 (11:22 +0200)
commitc8fd51dc12c6e22bb97d5e273babcf339770aba5
tree334902c961b74e0af2ac437a7f7e5f85eebc559b
parentaf43c4086cf24c3eb74a968195351163750c82b6
HID: i2c-hid: fix harmless test_bit() issue

These defines are used like this:

if (test_bit(I2C_HID_STARTED, &ihid->flags))

The intent was to use bits 0, 1, and 2 but because of the extra shifts
we're using bits 1, 2, and 4.  It's harmless becuase it's done
consistently but it's not the intent and static checkers will complain.

Fixes: 4a200c3b9a40 ('HID: i2c-hid: introduce HID over i2c specification implementation')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/i2c-hid/i2c-hid.c