]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
sata_mv: remove pointless NULL test
authorJeff Garzik <jeff@garzik.org>
Thu, 17 Dec 2009 06:23:16 +0000 (01:23 -0500)
committerJeff Garzik <jgarzik@redhat.com>
Thu, 17 Dec 2009 06:23:16 +0000 (01:23 -0500)
Remove !ap test, where ap is guaranteed not-NULL.  Found by way of automated
bug report from Alexander Strakh via "Linux Device Drivers Verification
Project (Svace Detector)"

Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
drivers/ata/sata_mv.c

index 73768195ccc229255c0d36af103ca1147fd13398..df8ee325d3ca3869c1fb6609a3432d590178d8c7 100755 (executable)
@@ -2781,7 +2781,7 @@ static void mv_port_intr(struct ata_port *ap, u32 port_cause)
        struct mv_port_priv *pp;
        int edma_was_enabled;
 
-       if (!ap || (ap->flags & ATA_FLAG_DISABLED)) {
+       if (ap->flags & ATA_FLAG_DISABLED) {
                mv_unexpected_intr(ap, 0);
                return;
        }