]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
pinctrl: single: Fix build when not built on ARM
authorTony Lindgren <tony@atomide.com>
Fri, 18 Oct 2013 23:20:05 +0000 (16:20 -0700)
committerTony Lindgren <tony@atomide.com>
Fri, 18 Oct 2013 23:43:06 +0000 (16:43 -0700)
Looks like we need a little bit of arch specific handling
with the generic IRQ. Fix the issue with an ifdef the
same way as other drivers do.

ARM needs things set to IRQF_VALID, which also then sets
noprobe. Others seem to use just irq_set_noprobe().

Otherwise we can get:

drivers/pinctrl/pinctrl-single.c: In function 'pcs_irqdomain_map':
drivers/pinctrl/pinctrl-single.c:1750:2: error: implicit declaration of function 'set_irq_flags' [-Werror=implicit-function-declaration]
drivers/pinctrl/pinctrl-single.c:1750:21: error: 'IRQF_VALID' undeclared (first use in this function)
drivers/pinctrl/pinctrl-single.c:1750:34: error: 'IRQF_PROBE' undeclared (first use in this function)

Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Tony Lindgren <tony@atomide.com>
drivers/pinctrl/pinctrl-single.c

index c2aada71c9150d623b35fbb76944801d4e9e4432..0846922b2316d0774e4f154aee45256c6019a41a 100644 (file)
@@ -1747,7 +1747,12 @@ static int pcs_irqdomain_map(struct irq_domain *d, unsigned int irq,
        irq_set_chip_data(irq, pcs_soc);
        irq_set_chip_and_handler(irq, &pcs->chip,
                                 handle_level_irq);
-       set_irq_flags(irq, IRQF_VALID | IRQF_PROBE);
+
+#ifdef CONFIG_ARM
+       set_irq_flags(irq, IRQF_VALID);
+#else
+       irq_set_noprobe(irq);
+#endif
 
        return 0;
 }