]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
[media] tc358743: add missing Kconfig dependency/select
authorHans Verkuil <hverkuil@xs4all.nl>
Wed, 19 Aug 2015 06:27:27 +0000 (03:27 -0300)
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>
Thu, 3 Sep 2015 16:47:07 +0000 (13:47 -0300)
As reported by Randy:
> when CONFIG_MEDIA_CONTROLLER is not enabled:
>
> ../drivers/media/i2c/tc358743.c: In function 'tc358743_probe':
> ../drivers/media/i2c/tc358743.c:1890:29: error: 'struct v4l2_subdev' has no member named 'entity'
>   err = media_entity_init(&sd->entity, 1, &state->pad, 0);
>                              ^
> ../drivers/media/i2c/tc358743.c:1940:26: error: 'struct v4l2_subdev' has no member named 'entity'
>   media_entity_cleanup(&sd->entity);
>                           ^
> ../drivers/media/i2c/tc358743.c: In function 'tc358743_remove':
> ../drivers/media/i2c/tc358743.c:1955:26: error: 'struct v4l2_subdev' has no member named 'entity'
>   media_entity_cleanup(&sd->entity);
>                           ^

This driver depends on VIDEO_V4L2_SUBDEV_API and needs to select HDMI.

Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
drivers/media/i2c/Kconfig

index d669547604cd157df243c03033f59203a42cb365..521bbf1b29bc574350320a20113a2d40d8d1a455 100644 (file)
@@ -289,7 +289,8 @@ config VIDEO_SAA711X
 
 config VIDEO_TC358743
        tristate "Toshiba TC358743 decoder"
-       depends on VIDEO_V4L2 && I2C
+       depends on VIDEO_V4L2 && I2C && VIDEO_V4L2_SUBDEV_API
+       select HDMI
        ---help---
          Support for the Toshiba TC358743 HDMI to MIPI CSI-2 bridge.