]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
ALSA: hda - Reduce verbs by node power-saves
authorTakashi Iwai <tiwai@suse.de>
Wed, 20 May 2015 04:49:37 +0000 (06:49 +0200)
committerTakashi Iwai <tiwai@suse.de>
Wed, 20 May 2015 04:49:37 +0000 (06:49 +0200)
The widget (node) power-saves restore the widget states at each
transition from D3 to D0 on each node.  This was added in the commit
[d545a57c5f84:ALSA: hda - Sync node attributes at resume from widget
power saving].  However, the test was rater false-positive; this
wasn't needed for any codecs.

Since the resync may take significant number of additional verbs to be
executed, it's better to reduce it.  Let's disable it for now again.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/hda/hda_generic.c

index 788f969b1a680e50f61940e31fe1a4609ccce402..1c8678775f4078df5b747a0a259b8c6ef33fb38b 100644 (file)
@@ -844,8 +844,16 @@ static hda_nid_t path_power_update(struct hda_codec *codec,
                        snd_hda_codec_write(codec, nid, 0,
                                            AC_VERB_SET_POWER_STATE, state);
                        changed = nid;
+                       /* all known codecs seem to be capable to handl
+                        * widgets state even in D3, so far.
+                        * if any new codecs need to restore the widget
+                        * states after D0 transition, call the function
+                        * below.
+                        */
+#if 0 /* disabled */
                        if (state == AC_PWRST_D0)
                                snd_hdac_regmap_sync_node(&codec->core, nid);
+#endif
                }
        }
        return changed;