]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
bus: mvebu: add missing of_node_put() to fix reference leak
authorJisheng Zhang <jszhang@marvell.com>
Tue, 27 Aug 2013 04:41:15 +0000 (12:41 +0800)
committerJason Cooper <jason@lakedaemon.net>
Wed, 18 Sep 2013 16:41:10 +0000 (16:41 +0000)
Add of_node_put to properly decrement the refcount when we are
done using a given node.

Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
Reviewed-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
Conflicts:
drivers/bus/mvebu-mbus.c

drivers/bus/mvebu-mbus.c

index 19ab6ff53d59776cedc592a5b18c2fba8fe02a65..553185318963939cc14c30d6fd9cfb9f898728b1 100644 (file)
@@ -700,6 +700,7 @@ static int __init mvebu_mbus_common_init(struct mvebu_mbus_state *mbus,
                                         phys_addr_t sdramwins_phys_base,
                                         size_t sdramwins_size)
 {
+       struct device_node *np;
        int win;
 
        mbus->mbuswins_base = ioremap(mbuswins_phys_base, mbuswins_size);
@@ -712,8 +713,11 @@ static int __init mvebu_mbus_common_init(struct mvebu_mbus_state *mbus,
                return -ENOMEM;
        }
 
-       if (of_find_compatible_node(NULL, NULL, "marvell,coherency-fabric"))
+       np = of_find_compatible_node(NULL, NULL, "marvell,coherency-fabric");
+       if (np) {
                mbus->hw_io_coherency = 1;
+               of_node_put(np);
+       }
 
        for (win = 0; win < mbus->soc->num_wins; win++)
                mvebu_mbus_disable_window(mbus, win);