]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
renesas: missing unlock on error path
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 24 Jun 2015 14:32:54 +0000 (17:32 +0300)
committerDavid S. Miller <davem@davemloft.net>
Thu, 25 Jun 2015 09:13:02 +0000 (02:13 -0700)
We need to unlock before returning here.

Fixes: a0d2f20650e8 ('Renesas Ethernet AVB PTP clock driver')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/renesas/ravb_ptp.c

index 42656da5050063ca382a6bb24375ec08ff672385..7a8ce920c49e709b067321ae91306153f4f24390 100644 (file)
@@ -116,8 +116,10 @@ static int ravb_ptp_adjfreq(struct ptp_clock_info *ptp, s32 ppb)
        priv->ptp.current_addend = addend;
 
        gccr = ravb_read(ndev, GCCR);
-       if (gccr & GCCR_LTI)
+       if (gccr & GCCR_LTI) {
+               spin_unlock_irqrestore(&priv->lock, flags);
                return -EBUSY;
+       }
        ravb_write(ndev, addend & GTI_TIV, GTI);
        ravb_write(ndev, gccr | GCCR_LTI, GCCR);