]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
iio: magnetometer: correct a harmless off by one check
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 27 May 2015 08:20:52 +0000 (11:20 +0300)
committerJonathan Cameron <jic23@kernel.org>
Mon, 1 Jun 2015 15:55:19 +0000 (16:55 +0100)
The line before limits i to 0-3 so the existing code works fine but the
check is still off by one and >= is intended instead of >.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
drivers/iio/magnetometer/mmc35240.c

index aa6e25d3bfc3544f757995ffe317d8a3b171ac5f..c71392cf13706490cb466acc9e21b830f8d4e67a 100644 (file)
@@ -308,7 +308,7 @@ static int mmc35240_read_raw(struct iio_dev *indio_dev,
                        return ret;
 
                i = (reg & MMC35240_CTRL1_BW_MASK) >> MMC35240_CTRL1_BW_SHIFT;
-               if (i < 0 || i > ARRAY_SIZE(mmc35240_samp_freq))
+               if (i < 0 || i >= ARRAY_SIZE(mmc35240_samp_freq))
                        return -EINVAL;
 
                *val = mmc35240_samp_freq[i];