]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
parport: dead code in pp_write
authorAlan Cox <alan@linux.intel.com>
Mon, 1 Oct 2012 15:24:17 +0000 (16:24 +0100)
committerJiri Kosina <jkosina@suse.cz>
Mon, 15 Oct 2012 20:46:41 +0000 (22:46 +0200)
We always update bytes_written before we check signal_pending so it
follows that we can't get a signal return for 0 bytes so we don't
need to check in the singal path. The cases a signal causes an earlier
abort are handled before this and will not hit this path

Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/char/ppdev.c

index 3fcf80ff12f2226fce01f5749e96972d3857072b..99c51b4b07e71c9804f6aa436dda95f631bb3e24 100644 (file)
@@ -251,12 +251,8 @@ static ssize_t pp_write (struct file * file, const char __user * buf,
                        break;
                }
 
-               if (signal_pending (current)) {
-                       if (!bytes_written) {
-                               bytes_written = -EINTR;
-                       }
+               if (signal_pending (current))
                        break;
-               }
 
                cond_resched();
        }