]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
scripts/coccinelle: check for field address argument to kfree
authorJulia Lawall <Julia.Lawall@lip6.fr>
Sat, 8 Jun 2013 16:21:42 +0000 (18:21 +0200)
committerMichal Marek <mmarek@suse.cz>
Fri, 14 Jun 2013 13:33:08 +0000 (15:33 +0200)
The argument to kfree should not be the address of a structure field.

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Michal Marek <mmarek@suse.cz>
scripts/coccinelle/free/kfreeaddr.cocci [new file with mode: 0644]

diff --git a/scripts/coccinelle/free/kfreeaddr.cocci b/scripts/coccinelle/free/kfreeaddr.cocci
new file mode 100644 (file)
index 0000000..662e997
--- /dev/null
@@ -0,0 +1,32 @@
+/// Free of a structure field
+///
+// Confidence: High
+// Copyright: (C) 2013 Julia Lawall, INRIA/LIP6.  GPLv2.
+// URL: http://coccinelle.lip6.fr/
+// Comments:
+// Options: -no_includes -include_headers
+
+virtual org
+virtual report
+virtual context
+
+@r depends on context || report || org @
+expression e;
+identifier f;
+position p;
+@@
+
+* kfree@p(&e->f)
+
+@script:python depends on org@
+p << r.p;
+@@
+
+cocci.print_main("kfree",p)
+
+@script:python depends on report@
+p << r.p;
+@@
+
+msg = "ERROR: kfree of structure field"
+coccilib.report.print_report(p[0],msg)