]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
drm/prime: Remove PRIME handles only if supported
authorThierry Reding <thierry.reding@gmail.com>
Wed, 28 Aug 2013 10:04:14 +0000 (12:04 +0200)
committerDave Airlie <airlied@gmail.com>
Thu, 29 Aug 2013 23:11:59 +0000 (09:11 +1000)
Drivers that don't support PRIME will not have initialized the PRIME
specific private component of struct drm_file. If called for such
drivers, the drm_gem_remove_prime_handles() function will crash. Fix
it by checking for PRIME support prior to removing the PRIME handles.

Signed-off-by: Thierry Reding <treding@nvidia.com>
Signed-off-by: Dave Airlie <airlied@gmail.com>
drivers/gpu/drm/drm_gem.c

index b2d59b2d3acc8d2448829c608fa5193a1efed388..49293bdc972a0d76143b0bd3b205280d4fffbd9e 100644 (file)
@@ -297,7 +297,8 @@ drm_gem_handle_delete(struct drm_file *filp, u32 handle)
        idr_remove(&filp->object_idr, handle);
        spin_unlock(&filp->table_lock);
 
-       drm_gem_remove_prime_handles(obj, filp);
+       if (drm_core_check_feature(dev, DRIVER_PRIME))
+               drm_gem_remove_prime_handles(obj, filp);
        drm_vma_node_revoke(&obj->vma_node, filp->filp);
 
        if (dev->driver->gem_close_object)
@@ -706,7 +707,8 @@ drm_gem_object_release_handle(int id, void *ptr, void *data)
        struct drm_gem_object *obj = ptr;
        struct drm_device *dev = obj->dev;
 
-       drm_gem_remove_prime_handles(obj, file_priv);
+       if (drm_core_check_feature(dev, DRIVER_PRIME))
+               drm_gem_remove_prime_handles(obj, file_priv);
        drm_vma_node_revoke(&obj->vma_node, file_priv->filp);
 
        if (dev->driver->gem_close_object)