]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
max17042_battery: Fix missing verify_model_lock() return value check
authorAlan Cox <alan@lxorguk.ukuu.org.uk>
Sun, 18 Nov 2012 22:59:47 +0000 (14:59 -0800)
committerAnton Vorontsov <anton.vorontsov@linaro.org>
Sun, 18 Nov 2012 22:59:47 +0000 (14:59 -0800)
The second error check is unreachable because the lock function isn't
assigned to ret.

Signed-off-by: Alan Cox <alan@linux.intel.com>
Acked-by: Ramakrishna Pallala <ramakrishna.pallala@intel.com>
Signed-off-by: Anton Vorontsov <anton.vorontsov@linaro.org>
drivers/power/max17042_battery.c

index 74abc6c755b498bf023fcd540b9232743f1cd744..66b2c7b509149beefe5ea7f4e3e6c3f31366b46f 100644 (file)
@@ -572,7 +572,8 @@ static int max17042_init_chip(struct max17042_chip *chip)
                        __func__);
                return -EIO;
        }
-       max17042_verify_model_lock(chip);
+
+       ret = max17042_verify_model_lock(chip);
        if (ret) {
                dev_err(&chip->client->dev, "%s lock verify failed\n",
                        __func__);