staging: unisys: move visorchipset files to visorbus

Move visorchipset_main.c and visorchipset.h to visorbus/visorchipset.c and
visorbus/visorbus_private.h.  This leaves an empty visorchipset directory
which can also be destroyed.

As a result of this patch the visorchipset init code now calls the
visorbus_init() directly.  Similarily the visorchipset exit code now
cleans up by calling visorbus_exit().

No other functional changes were made.

Signed-off-by: Prarit Bhargava <prarit@redhat.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/unisys/Kconfig b/drivers/staging/unisys/Kconfig
index dbdd4492cf0f1d4dc6b15cbeb56fa50ad5140e26..50223c74eb5049fc080d890b18d84e553ace1146 100644 (file)
--- a/drivers/staging/unisys/Kconfig
+++ b/drivers/staging/unisys/Kconfig
@@ -10,7 +10,6 @@ menuconfig UNISYSSPAR
 if UNISYSSPAR
 
 source "drivers/staging/unisys/visorutil/Kconfig"
-source "drivers/staging/unisys/visorchipset/Kconfig"
 source "drivers/staging/unisys/visorbus/Kconfig"
 
 endif # UNISYSSPAR

diff --git a/drivers/staging/unisys/Makefile b/drivers/staging/unisys/Makefile
index b14a4777fd48f110a9749c9216fa515d3af333bf..e0c893a6e870b33e27053512a2bf67c434e394d8 100644 (file)
--- a/drivers/staging/unisys/Makefile
+++ b/drivers/staging/unisys/Makefile
@@ -2,5 +2,4 @@
 # Makefile for Unisys SPAR drivers
 #
 obj-$(CONFIG_UNISYS_VISORUTIL)         += visorutil/
-obj-$(CONFIG_UNISYS_VISORCHIPSET)      += visorchipset/
 obj-$(CONFIG_UNISYS_VISORBUS)          += visorbus/

diff --git a/drivers/staging/unisys/visorbus/Kconfig b/drivers/staging/unisys/visorbus/Kconfig
index 12cf8f06355072f718ca86cd00a56f0c601651f1..420c9eee9075f84f008926c3e416cf5e1705e268 100644 (file)
--- a/drivers/staging/unisys/visorbus/Kconfig
+++ b/drivers/staging/unisys/visorbus/Kconfig
@@ -4,6 +4,6 @@
 
 config UNISYS_VISORBUS
        tristate "Unisys visorbus driver"
-       depends on UNISYSSPAR && UNISYS_VISORUTIL && UNISYS_VISORCHIPSET
+       depends on UNISYSSPAR && UNISYS_VISORUTIL
        ---help---
        If you say Y here, you will enable the Unisys visorbus driver.

diff --git a/drivers/staging/unisys/visorbus/Makefile b/drivers/staging/unisys/visorbus/Makefile
index 7151690695f56136d02cb901f9563483d48b79dd..16d3ff507a0ad265654fcb958b524a3d209c6f88 100644 (file)
--- a/drivers/staging/unisys/visorbus/Makefile
+++ b/drivers/staging/unisys/visorbus/Makefile
@@ -6,9 +6,9 @@ obj-$(CONFIG_UNISYS_VISORBUS)   += visorbus.o
 
 visorbus-y := visorbus_main.o
 visorbus-y += visorchannel.o
+visorbus-y += visorchipset.o
 
 ccflags-y += -Idrivers/staging/unisys/include
-ccflags-y += -Idrivers/staging/unisys/visorchipset
 ccflags-y += -Idrivers/staging/unisys/common-spar/include
 ccflags-y += -Idrivers/staging/unisys/common-spar/include/channels
 ccflags-y += -Idrivers/staging/unisys/visorutil

diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c b/drivers/staging/unisys/visorbus/visorbus_main.c
index d7ca1163c1b178587813404c43270d40c680074e..6c939ce503a1a6288eff44ce7a0f14cc45fd01f3 100644 (file)
--- a/drivers/staging/unisys/visorbus/visorbus_main.c
+++ b/drivers/staging/unisys/visorbus/visorbus_main.c
@@ -18,7 +18,7 @@
 #include <linux/uuid.h>
 
 #include "visorbus.h"
-#include "visorchipset.h"
+#include "visorbus_private.h"
 #include "version.h"
 #include "timskmod.h"
 #include "periodic_work.h"
@@ -26,6 +26,8 @@
 #include "guestlinuxdebug.h"
 #include "vbusdeviceinfo.h"
 
+#define MYDRVNAME "visorbus"
+
 /* module parameters */
 int visorbus_debug;
 int visorbus_forcematch;
@@ -2033,7 +2035,7 @@ struct channel_size_info {
        unsigned long max_size;
 };
 
-static int __init
+int __init
 visorbus_init(void)
 {
        int rc = 0;
@@ -2077,7 +2079,7 @@ away:
        return rc;
 }
 
-static void
+void
 visorbus_exit(void)
 {
        struct list_head *listentry, *listtmp;
@@ -2135,9 +2137,6 @@ MODULE_PARM_DESC(visorbus_serialloopbacktest,
                 "non-0 to just create 2 serial devices on the same channel");
 int visorbus_serialloopbacktest = 0;
 
-module_init(visorbus_init);
-module_exit(visorbus_exit);
-
 MODULE_AUTHOR("Unisys");
 MODULE_LICENSE("GPL");
 MODULE_DESCRIPTION("Supervisor bus driver for service partition: ver " VERSION);

diff --git a/drivers/staging/unisys/visorchipset/visorchipset.h b/drivers/staging/unisys/visorbus/visorbus_private.h
similarity index 98%
rename from drivers/staging/unisys/visorchipset/visorchipset.h
rename to drivers/staging/unisys/visorbus/visorbus_private.h
index 264a3e9226ea50938e949c63fad02e2265c78df4..68d770f29115366d07949213205da14ab9708da4 100644 (file)
--- a/drivers/staging/unisys/visorchipset/visorchipset.h
+++ b/drivers/staging/unisys/visorbus/visorbus_private.h
@@ -211,4 +211,8 @@ void visorchipset_cache_free(struct kmem_cache *pool, void *p,
 int visorchipset_file_init(dev_t majorDev,
                           struct visorchannel **pControlVm_channel);
 void visorchipset_file_cleanup(dev_t major_dev);
+
+/* visorbus init and exit functions */
+int __init visorbus_init(void);
+void visorbus_exit(void);
 #endif

diff --git a/drivers/staging/unisys/visorchipset/visorchipset_main.c b/drivers/staging/unisys/visorbus/visorchipset.c
similarity index 99%
rename from drivers/staging/unisys/visorchipset/visorchipset_main.c
rename to drivers/staging/unisys/visorbus/visorchipset.c
index dc9f1dc183064972789ab56695766239d758cae6..f3a2145ac3ce2fef248f4ea7abb913d4a2a454b0 100644 (file)
--- a/drivers/staging/unisys/visorchipset/visorchipset_main.c
+++ b/drivers/staging/unisys/visorbus/visorchipset.c
@@ -24,7 +24,7 @@
 #include "uisutils.h"
 #include "controlvmcompletionstatus.h"
 #include "guestlinuxdebug.h"
-#include "visorchipset.h"
+#include "visorbus_private.h"
 
 
 #include <linux/ctype.h>
@@ -168,7 +168,7 @@ static struct visor_livedump_info livedump_info;
  * process it again the next time controlvm_periodic_work() runs.
  */
 static struct controlvm_message controlvm_pending_msg;
-static bool controlvm_pending_msg_valid = false;
+static bool controlvm_pending_msg_valid;
 
 /* This identifies a data buffer that has been received via a controlvm messages
  * in a remote --> local CONTROLVM_TRANSMIT_FILE conversation.
@@ -2783,7 +2783,8 @@ visorchipset_init(void)
                goto cleanup;
        }
        POSTCODE_LINUX_2(CHIPSET_INIT_SUCCESS_PC, POSTCODE_SEVERITY_INFO);
-       rc = 0;
+
+       rc = visorbus_init();
 cleanup:
        if (rc) {
                POSTCODE_LINUX_3(CHIPSET_INIT_FAILURE_PC, rc,
@@ -2806,6 +2807,8 @@ visorchipset_exit(void)
 {
        POSTCODE_LINUX_2(DRIVER_EXIT_PC, POSTCODE_SEVERITY_INFO);
 
+       visorbus_exit();
+
        if (visorchipset_disable_controlvm) {
                ;
        } else {

diff --git a/drivers/staging/unisys/visorchipset/Kconfig b/drivers/staging/unisys/visorchipset/Kconfig
deleted file mode 100644 (file)
index 01d9a9a..0000000
--- a/drivers/staging/unisys/visorchipset/Kconfig
+++ /dev/null
@@ -1,11 +0,0 @@
-#
-# Unisys visorchipset configuration
-#
-
-config UNISYS_VISORCHIPSET
-       tristate "Unisys visorchipset driver"
-       select UNISYS_VISORUTIL
-       select UNISYS_VISORBUS
-       ---help---
-       If you say Y here, you will enable the Unisys visorchipset driver.
-

diff --git a/drivers/staging/unisys/visorchipset/Makefile b/drivers/staging/unisys/visorchipset/Makefile
deleted file mode 100644 (file)
index e9168d8..0000000
--- a/drivers/staging/unisys/visorchipset/Makefile
+++ /dev/null
@@ -1,15 +0,0 @@
-#
-# Makefile for Unisys visorchipset
-#
-
-obj-$(CONFIG_UNISYS_VISORCHIPSET)      += visorchipset.o
-
-visorchipset-y := visorchipset_main.o
-
-ccflags-y += -Idrivers/staging/unisys/include
-ccflags-y += -Idrivers/staging/unisys/uislib
-ccflags-y += -Idrivers/staging/unisys/common-spar/include
-ccflags-y += -Idrivers/staging/unisys/common-spar/include/channels
-ccflags-y += -Idrivers/staging/unisys/visorutil
-ccflags-y += -Idrivers/staging/unisys/visorbus
-ccflags-y += -Iinclude/generated