]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
net: hns: fix 32-bit build warning
authorArnd Bergmann <arnd@arndb.de>
Tue, 6 Oct 2015 21:53:57 +0000 (23:53 +0200)
committerDavid S. Miller <davem@davemloft.net>
Thu, 8 Oct 2015 11:54:15 +0000 (04:54 -0700)
The recently added hns driver causes a build warning in ARM
allmodconfig builds:

drivers/net/ethernet/hisilicon/hns/hnae.c: In function 'handles_show':
drivers/net/ethernet/hisilicon/hns/hnae.c:452:13: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
          j, (u64)h->qs[i]->io_base);
             ^

This removes the pointless cast and prints the pointer address using
the "%p" format string in all three locations.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/hisilicon/hns/hnae.c

index 0a0a9e80dcd77d0ab8be4fa5f83b92b87469d586..f52e99acf46342afcb657af10e59df5ae6d18fe4 100644 (file)
@@ -448,12 +448,12 @@ static ssize_t handles_show(struct device *dev,
                s += sprintf(buf + s, "handle %d (eport_id=%u from %s):\n",
                            i++, h->eport_id, h->dev->name);
                for (j = 0; j < h->q_num; j++) {
-                       s += sprintf(buf + s, "\tqueue[%d] on 0x%llx\n",
-                                    j, (u64)h->qs[i]->io_base);
-#define HANDEL_TX_MSG "\t\ttx_ring on 0x%llx:%u,%u,%u,%u,%u,%llu,%llu\n"
+                       s += sprintf(buf + s, "\tqueue[%d] on %p\n",
+                                    j, h->qs[i]->io_base);
+#define HANDEL_TX_MSG "\t\ttx_ring on %p:%u,%u,%u,%u,%u,%llu,%llu\n"
                        s += sprintf(buf + s,
                                     HANDEL_TX_MSG,
-                                    (u64)h->qs[i]->tx_ring.io_base,
+                                    h->qs[i]->tx_ring.io_base,
                                     h->qs[i]->tx_ring.buf_size,
                                     h->qs[i]->tx_ring.desc_num,
                                     h->qs[i]->tx_ring.max_desc_num_per_pkt,
@@ -462,8 +462,8 @@ static ssize_t handles_show(struct device *dev,
                                 h->qs[i]->tx_ring.stats.sw_err_cnt,
                                 h->qs[i]->tx_ring.stats.io_err_cnt);
                        s += sprintf(buf + s,
-                               "\t\trx_ring on 0x%llx:%u,%u,%llu,%llu,%llu\n",
-                               (u64)h->qs[i]->rx_ring.io_base,
+                               "\t\trx_ring on %p:%u,%u,%llu,%llu,%llu\n",
+                               h->qs[i]->rx_ring.io_base,
                                h->qs[i]->rx_ring.buf_size,
                                h->qs[i]->rx_ring.desc_num,
                                h->qs[i]->rx_ring.stats.sw_err_cnt,