]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
vfs: fix d_inode_lookup() dentry ref leak
authorMiklos Szeredi <mszeredi@suse.cz>
Fri, 3 Feb 2012 13:25:18 +0000 (14:25 +0100)
committerAl Viro <viro@zeniv.linux.org.uk>
Tue, 14 Feb 2012 01:45:37 +0000 (20:45 -0500)
d_inode_lookup() leaks a dentry reference on IS_DEADDIR().

Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
CC: stable@vger.kernel.org
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fs/namei.c

index 208c6aa4a989dade864a0ca6fcd3bd4b21ba8252..a780ea515c47988623fc4954b734562182ed24c5 100644 (file)
@@ -1095,8 +1095,10 @@ static struct dentry *d_inode_lookup(struct dentry *parent, struct dentry *dentr
        struct dentry *old;
 
        /* Don't create child dentry for a dead directory. */
-       if (unlikely(IS_DEADDIR(inode)))
+       if (unlikely(IS_DEADDIR(inode))) {
+               dput(dentry);
                return ERR_PTR(-ENOENT);
+       }
 
        old = inode->i_op->lookup(inode, dentry, nd);
        if (unlikely(old)) {