]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
[media] cx231xx: fix handling cx231xx_read_i2c_data result
authorAndrzej Hajda <a.hajda@samsung.com>
Thu, 24 Sep 2015 14:00:18 +0000 (11:00 -0300)
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>
Sat, 3 Oct 2015 14:32:32 +0000 (11:32 -0300)
The function can return negative value.

The problem has been detected using proposed semantic patch
scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1].

[1]: http://permalink.gmane.org/gmane.linux.kernel/2046107

Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
drivers/media/usb/cx231xx/cx231xx-video.c

index 9798160698a359ad4c56cdf1f82018a53c0d0d30..d0d8f08e37c8706baf94552ed85a6149491e080a 100644 (file)
@@ -1114,7 +1114,8 @@ int cx231xx_enum_input(struct file *file, void *priv,
        struct cx231xx_fh *fh = priv;
        struct cx231xx *dev = fh->dev;
        u32 gen_stat;
-       unsigned int ret, n;
+       unsigned int n;
+       int ret;
 
        n = i->index;
        if (n >= MAX_CX231XX_INPUT)