]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
mfd: menelaus: Remove incorrect __exit markups
authorDmitry Torokhov <dmitry.torokhov@gmail.com>
Mon, 9 Mar 2015 17:49:36 +0000 (10:49 -0700)
committerLee Jones <lee.jones@linaro.org>
Mon, 23 Mar 2015 11:47:38 +0000 (11:47 +0000)
Even if bus is not hot-pluggable, the devices can be unbound from the
driver via sysfs, so we should not be using __exit annotations on
remove() methods. The only exception is drivers registered with
platform_driver_probe() which specifically disables sysfs bind/unbind
attributes.

Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Acked-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
drivers/mfd/menelaus.c

index 9f01aef539ddd7a21a3958548b0c856b4138fff6..5269ff2f29bcae2d7fca6b9c4a379eab5939b828 100644 (file)
@@ -1259,7 +1259,7 @@ fail:
        return err;
 }
 
-static int __exit menelaus_remove(struct i2c_client *client)
+static int menelaus_remove(struct i2c_client *client)
 {
        struct menelaus_chip    *menelaus = i2c_get_clientdata(client);
 
@@ -1280,7 +1280,7 @@ static struct i2c_driver menelaus_i2c_driver = {
                .name           = DRIVER_NAME,
        },
        .probe          = menelaus_probe,
-       .remove         = __exit_p(menelaus_remove),
+       .remove         = menelaus_remove,
        .id_table       = menelaus_id,
 };