]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
IBM-EMAC: Delete an unnecessary check before the function call "of_dev_put"
authorMarkus Elfring <elfring@users.sourceforge.net>
Tue, 3 Feb 2015 18:47:33 +0000 (19:47 +0100)
committerDavid S. Miller <davem@davemloft.net>
Thu, 5 Feb 2015 04:29:47 +0000 (20:29 -0800)
The of_dev_put() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/ibm/emac/core.c

index 9388a83818f2f408446654adef22cb7020d567ab..162762d1a12cb1ffcb34a2325150278650168c29 100644 (file)
@@ -2367,7 +2367,7 @@ static int emac_wait_deps(struct emac_instance *dev)
        err = emac_check_deps(dev, deps) ? 0 : -ENODEV;
        for (i = 0; i < EMAC_DEP_COUNT; i++) {
                of_node_put(deps[i].node);
-               if (err && deps[i].ofdev)
+               if (err)
                        of_dev_put(deps[i].ofdev);
        }
        if (err == 0) {