]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
ASoC: atmel-pdmic: Simplify use of devm_ioremap_resource
authorAmitoj Kaur Chawla <amitoj1606@gmail.com>
Mon, 4 Jul 2016 13:07:06 +0000 (18:37 +0530)
committerMark Brown <broonie@kernel.org>
Mon, 4 Jul 2016 14:15:13 +0000 (16:15 +0200)
Remove unneeded error handling on the result of a call to
platform_get_resource when the value is passed to
devm_ioremap_resource.

The Coccinelle semantic patch that makes this change is as follows:

// <smpl>
@@
expression pdev,res,n,e,e1;
expression ret != 0;
identifier l;
@@

- res = platform_get_resource(pdev, IORESOURCE_MEM, n);
  ... when != res
- if (res == NULL) { ... \(goto l;\|return ret;\) }
  ... when != res
+ res = platform_get_resource(pdev, IORESOURCE_MEM, n);
  e = devm_ioremap_resource(e1, res);
// </smpl>

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/atmel/atmel-pdmic.c

index aee4787a0b89f4a4ad5b28f0981b7e67d201dbb5..5f56da60c92ff6398d3eba82ab2ce7e0b75fd649 100644 (file)
@@ -624,11 +624,6 @@ static int atmel_pdmic_probe(struct platform_device *pdev)
        }
 
        res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-       if (!res) {
-               dev_err(dev, "no memory resource\n");
-               return -ENXIO;
-       }
-
        io_base = devm_ioremap_resource(dev, res);
        if (IS_ERR(io_base)) {
                ret = PTR_ERR(io_base);